This is the mail archive of the
mauve-patches@sourceware.org
mailing list for the Mauve project.
FYI: Rectangle.setRect() test updated
- From: David Gilbert <david dot gilbert at object-refinery dot com>
- To: mauve-patches at sources dot redhat dot com
- Date: Mon, 04 Sep 2006 10:02:34 +0100
- Subject: FYI: Rectangle.setRect() test updated
This patch (committed) adds some additional checks for the setRect() method:
2006-09-04 David Gilbert <david.gilbert@object-refinery.com>
* gnu/testlet/java/awt/Rectangle/setRect.java
(test): Added new checks for input rounding.
Regards,
Dave
Index: gnu/testlet/java/awt/Rectangle/setRect.java
===================================================================
RCS file: /cvs/mauve/mauve/gnu/testlet/java/awt/Rectangle/setRect.java,v
retrieving revision 1.1
diff -u -r1.1 setRect.java
--- gnu/testlet/java/awt/Rectangle/setRect.java 12 Aug 2004 12:41:52 -0000 1.1
+++ gnu/testlet/java/awt/Rectangle/setRect.java 4 Sep 2006 08:59:36 -0000
@@ -1,21 +1,21 @@
-//Tags: JDK1.0
+// Tags: JDK1.2
-//Copyright (C) 2004 David Gilbert <david.gilbert@object-refinery.com>
+// Copyright (C) 2004, 2006 David Gilbert <david.gilbert@object-refinery.com>
-//Mauve is free software; you can redistribute it and/or modify
-//it under the terms of the GNU General Public License as published by
-//the Free Software Foundation; either version 2, or (at your option)
-//any later version.
-
-//Mauve is distributed in the hope that it will be useful,
-//but WITHOUT ANY WARRANTY; without even the implied warranty of
-//MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
-//GNU General Public License for more details.
-
-//You should have received a copy of the GNU General Public License
-//along with Mauve; see the file COPYING. If not, write to
-//the Free Software Foundation, 59 Temple Place - Suite 330,
-//Boston, MA 02111-1307, USA. */
+// Mauve is free software; you can redistribute it and/or modify
+// it under the terms of the GNU General Public License as published by
+// the Free Software Foundation; either version 2, or (at your option)
+// any later version.
+
+// Mauve is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+// GNU General Public License for more details.
+
+// You should have received a copy of the GNU General Public License
+// along with Mauve; see the file COPYING. If not, write to
+// the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
+// Boston, MA 02110-1301 USA.
package gnu.testlet.java.awt.Rectangle;
@@ -42,6 +42,30 @@
harness.check(r1.y == 6);
harness.check(r1.width == 7);
harness.check(r1.height == 8);
+
+ // test rounding - it seems that the code sets a rectangle that completely
+ // encloses the double precision rectangle
+ r1.setRect(5.9, 6.9, 7, 8);
+ harness.check(r1.x, 5);
+ harness.check(r1.y, 6);
+ harness.check(r1.width, 8);
+ harness.check(r1.height, 9);
+
+ r1.setRect(-0.1, -0.2, 0.3, 0.4);
+ harness.check(r1.x, -1);
+ harness.check(r1.y, -1);
+ harness.check(r1.width, 2);
+ harness.check(r1.height, 2);
+
+ // is negative width permitted?
+ r1.setRect(1.0, 2.0, -3.0, 4.0);
+ harness.check(r1.width, -3);
+ harness.check(r1.isEmpty());
+
+ // is negative height permitted?
+ r1.setRect(1.0, 2.0, 3.0, -4.0);
+ harness.check(r1.height, -4);
+ harness.check(r1.isEmpty());
}
}