This is the mail archive of the mauve-patches@sourceware.org mailing list for the Mauve project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: FYI: Graphics2D.setTransform() test


Hi David,

On Thu, 2006-06-08 at 15:59 +0100, David Gilbert wrote:
> 2006-06-08  David Gilbert  <david.gilbert@object-refinery.com>
> 
>     * gnu/testlet/java/awt/Graphics2D/setTransform.java: New file,
>     * gnu/testlet/java/awt/Graphics2D/transform.java: New file.

I changed these slightly to prevent some class cast exceptions.
getClip() returns a Shape. And at least the GNU Classpath implementation
sometimes just returns a GeneralPath instead of a Rectangle2D, probably
a missed optimization, but I don't think it is actually wrong, even
though the tests still fail of course.

2006-06-13  Mark Wielaard  <mark@klomp.org>

    * gnu/testlet/java/awt/Graphics2D/setTransform.java:
    getClip() returns a Shape.
    * gnu/testlet/java/awt/Graphics2D/transform.java: Likewise.

Committed,

Mark
Index: gnu/testlet/java/awt/Graphics2D/setTransform.java
===================================================================
RCS file: /cvs/mauve/mauve/gnu/testlet/java/awt/Graphics2D/setTransform.java,v
retrieving revision 1.1
diff -u -r1.1 setTransform.java
--- gnu/testlet/java/awt/Graphics2D/setTransform.java	8 Jun 2006 14:57:19 -0000	1.1
+++ gnu/testlet/java/awt/Graphics2D/setTransform.java	13 Jun 2006 07:37:27 -0000
@@ -28,6 +28,7 @@
 import gnu.testlet.Testlet;
 
 import java.awt.Graphics2D;
+import java.awt.Shape;
 import java.awt.geom.AffineTransform;
 import java.awt.geom.Rectangle2D;
 import java.awt.image.BufferedImage;
@@ -55,13 +56,13 @@
     // set...
     harness.check(g2.getTransform(), new AffineTransform());
     g2.setClip(1, 2, 3, 4);
-    Rectangle2D currentClip = (Rectangle2D) g2.getClip();
+    Shape currentClip = g2.getClip();
     harness.check(currentClip, new Rectangle2D.Double(1, 2, 3, 4));
     g2.transform(AffineTransform.getTranslateInstance(10.0, 20.0));
-    currentClip = (Rectangle2D) g2.getClip();
+    currentClip = g2.getClip();
     harness.check(currentClip, new Rectangle2D.Double(-9, -18, 3, 4));
     g2.setTransform(new AffineTransform());
-    currentClip = (Rectangle2D) g2.getClip();
+    currentClip = g2.getClip();
     harness.check(currentClip, new Rectangle2D.Double(1, 2, 3, 4));    
   }
 }
Index: gnu/testlet/java/awt/Graphics2D/transform.java
===================================================================
RCS file: /cvs/mauve/mauve/gnu/testlet/java/awt/Graphics2D/transform.java,v
retrieving revision 1.1
diff -u -r1.1 transform.java
--- gnu/testlet/java/awt/Graphics2D/transform.java	8 Jun 2006 14:57:19 -0000	1.1
+++ gnu/testlet/java/awt/Graphics2D/transform.java	13 Jun 2006 07:37:27 -0000
@@ -28,6 +28,7 @@
 import gnu.testlet.Testlet;
 
 import java.awt.Graphics2D;
+import java.awt.Shape;
 import java.awt.geom.AffineTransform;
 import java.awt.geom.Rectangle2D;
 import java.awt.image.BufferedImage;
@@ -65,10 +66,10 @@
     // applied...
     g2.setTransform(new AffineTransform());
     g2.setClip(1, 2, 3, 4);
-    Rectangle2D currentClip = (Rectangle2D) g2.getClip();
+    Shape currentClip = g2.getClip();
     harness.check(currentClip, new Rectangle2D.Double(1, 2, 3, 4));
     g2.transform(AffineTransform.getTranslateInstance(10.0, 20.0));
-    currentClip = (Rectangle2D) g2.getClip();
+    currentClip = g2.getClip();
     harness.check(currentClip, new Rectangle2D.Double(-9, -18, 3, 4));
   }
 }

Attachment: signature.asc
Description: This is a digitally signed message part


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]