This is the mail archive of the mauve-patches@sourceware.org mailing list for the Mauve project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Patch: TestPanelRepaint fix


Fixed up this test. It was incorrectly testing update.

2006-03-29  Lillian Angel  <langel@redhat.com>

        * gnu/testlet/java/awt/Panel/TestPanelRepaint.java
        (test): Added check.
        (myPanel): Added component listener.

Index: batch_run
===================================================================
RCS file: /cvs/mauve/mauve/batch_run,v
retrieving revision 1.20
diff -u -r1.20 batch_run
--- batch_run	19 Feb 2006 14:27:58 -0000	1.20
+++ batch_run	29 Mar 2006 23:14:30 -0000
@@ -38,7 +38,7 @@
 fi
 
 if test "x$CLASSPATHBCP" = "x"; then
-CLASSPATHBCP="/usr/local/classpath/share/classpath/glibj.zip"
+CLASSPATHBCP="/home/langel/sources/classpath/install/share/classpath"
 fi
 
 if test "x$COMPILER" = "x"; then
Index: .externalToolBuilders/MauveTestlet.launch
===================================================================
RCS file: /cvs/mauve/mauve/.externalToolBuilders/MauveTestlet.launch,v
retrieving revision 1.1
diff -u -r1.1 MauveTestlet.launch
--- .externalToolBuilders/MauveTestlet.launch	1 Jan 2006 20:26:40 -0000	1.1
+++ .externalToolBuilders/MauveTestlet.launch	29 Mar 2006 23:14:30 -0000
@@ -1,2 +1,11 @@
-<?xml version='1.0'?>
-<launchConfiguration type='org.eclipse.jdt.launching.localJavaApplication'><stringAttribute key='org.eclipse.jdt.launching.VM_INSTALL_NAME' value='classpath'/><stringAttribute key='org.eclipse.jdt.launching.PROGRAM_ARGUMENTS' value='${java_type_name}'/><stringAttribute key='org.eclipse.jdt.launching.VM_INSTALL_TYPE_ID' value='org.eclipse.jdt.internal.debug.ui.launcher.StandardVMType'/><listAttribute key='org.eclipse.debug.ui.favoriteGroups'><listEntry value='org.eclipse.debug.ui.launchGroup.debug'/><listEntry value='org.eclipse.debug.ui.launchGroup.run'/></listAttribute><booleanAttribute key='org.eclipse.debug.core.appendEnvironmentVariables' value='true'/><stringAttribute key='org.eclipse.jdt.launching.MAIN_TYPE' value='gnu.testlet.SingleTestHarness'/><stringAttribute key='org.eclipse.jdt.launching.PROJECT_ATTR' value='mauve'/></launchConfiguration>
+<?xml version="1.0" encoding="UTF-8"?>
+<launchConfiguration type="org.eclipse.jdt.launching.localJavaApplication">
+<stringAttribute key="org.eclipse.jdt.launching.MAIN_TYPE" value="gnu.testlet.SingleTestHarness"/>
+<stringAttribute key="org.eclipse.jdt.launching.PROGRAM_ARGUMENTS" value="${java_type_name}"/>
+<stringAttribute key="org.eclipse.jdt.launching.PROJECT_ATTR" value="mauve"/>
+<listAttribute key="org.eclipse.debug.ui.favoriteGroups">
+<listEntry value="org.eclipse.debug.ui.launchGroup.run"/>
+<listEntry value="org.eclipse.debug.ui.launchGroup.debug"/>
+</listAttribute>
+<booleanAttribute key="org.eclipse.debug.core.appendEnvironmentVariables" value="true"/>
+</launchConfiguration>
Index: gnu/testlet/java/awt/Panel/TestPanelRepaint.java
===================================================================
RCS file: /cvs/mauve/mauve/gnu/testlet/java/awt/Panel/TestPanelRepaint.java,v
retrieving revision 1.1
diff -u -r1.1 TestPanelRepaint.java
--- gnu/testlet/java/awt/Panel/TestPanelRepaint.java	6 Mar 2006 22:28:34 -0000	1.1
+++ gnu/testlet/java/awt/Panel/TestPanelRepaint.java	29 Mar 2006 23:14:40 -0000
@@ -30,16 +30,19 @@
 import java.awt.List;
 import java.awt.Panel;
 import java.awt.Robot;
-import java.awt.event.ComponentEvent;
+import java.awt.event.*;
 
 public class TestPanelRepaint
     implements Testlet
 {
   TestHarness harness;
-
+  Robot r;
+  boolean updateCalled;
+  
   public void test(TestHarness harness)
   {
     this.harness = harness;
+    r = harness.createRobot();
     myPanel p = new myPanel();
     p.add(new List(10));
     Frame f = new Frame();
@@ -47,32 +50,33 @@
     f.pack();
     f.show();
     
-    Robot r = harness.createRobot();
     // There is a delay to avoid any race conditions.    
     r.waitForIdle();
     r.delay(1000);
     
     f.move(100, 100);
     
-    r.delay(1000);
+    r.delay(3000);
     
     f.setSize(400, 400);
     
     // There is a delay so the tester can see the result.
     r.delay(3000);
+    harness.check(updateCalled);
   }
 
   public class myPanel
-      extends Panel
+      extends Panel implements ComponentListener
   {
     public myPanel()
     {
       super();
+      addComponentListener(this);
     }
 
     public void update(Graphics g)
     {
-      harness.fail("Update should not be called!");
+      updateCalled = true;
       super.update(g);
     }
 

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]