This is the mail archive of the mauve-patches@sourceware.org mailing list for the Mauve project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Patch: New Lightweight tests


On Wed, 2006-02-22 at 17:14 +0100, Michael Koch wrote:
> On Wed, Feb 22, 2006 at 09:51:39AM -0500, Lillian Angel wrote:
> > > >+    harness.checkRectangleOuterColors(r, bounds2, Color.red, true);
> > > >+    harness.checkRectangleCornerColors(r, bounds2, Color.red, false);
> > > >+    
> > > >+    r.delay(3000);
> > > >+  }
> > > >  
> > > >
> > > Do you know what the delay is for?  Is there some other way to write the 
> > > test so that the delay isn't required?  It's just that it would be nice 
> > > if the Mauve test run doesn't take longer than it has to - otherwise 
> > > hackers will stop running it.
> > 
> > It seemed that there were some race conditions when running these tests.
> > These delays were added to avoid them.
> 
> Then please document this in the testcase.

Sorry, my mistake. I will add it to the Frame and Container tests.

Lillian.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]