Re: Patch: New Test File.getParent

[Mark Wielaard <mark at klomp dot org>]

Hi Wolfgang,

On Sun, 2005-11-06 at 18:45 +0100, Wolfgang Baer wrote:
> 2005-10-28  Wolfgang Baer  <WBaer@gmx.de>
> 
>          * gnu/testlet/java/io/File/emptyFile.java: New test.

Cool, thanks.

Some small nitpicks. You are using spaces and tabs for indenting, but
not consistently. A try-catch block is written as follows in the GNU
style (if you want to follow that, not a strict requirement for Mauve,
but appreciated):

	try
	  {
	    testfile.createNewFile();
	    harness.check(false, "createNewFile()");
	  }
	catch (IOException e) 
	  {
	    harness.check(true, "createNewFile()");
	  }

Why do you have the following check at the start of the test?

>     SimpleTestHarness testharness = null;
>     try 
>     {
>           testharness = (SimpleTestHarness) harness;
>     } 
>     catch (ClassCastException cce)
>     {
>           harness.fail ("Harness not an instance of SimpleTestHarness");
>           return;
>     }

I couldn't find anything in your test that needs anything not in the
TestHarness interface.

Cheers,

Mark

Attachment: signature.asc
Description: This is a digitally signed message part