This is the mail archive of the
mauve-patches@sources.redhat.com
mailing list for the Mauve project.
java.text.MessageFormat
- From: David Gilbert <david dot gilbert at object-refinery dot com>
- To: mauve-patches at sources dot redhat dot com
- Date: Thu, 28 Oct 2004 12:00:34 +0100
- Subject: java.text.MessageFormat
I've committed the following new test for the format(String, Object[])
method in the MessageFormat class (see attached patch):
2004-10-28 David Gilbert <david.gilbert@object-refinery.com>
* gnu/testlet/java/net/MessageFormat/format14.java: New test.
All tests pass with Sun's JDK 1.4, but there are 5 failures with a
recent CVS version of Classpath (using JamVM 1.2.0):
dgilbert@linux42:~/workspace/mauve> jamvm -classpath .
gnu.testlet.SimpleTestHarness -file CurrentTests.txt -verbose -debug
gnu.testlet.java.text.MessageFormat.format14
----
PASS: gnu.testlet.java.text.MessageFormat.format14: static (String,
Object[]) (number 1)
PASS: gnu.testlet.java.text.MessageFormat.format14: static (String,
Object[]) (number 2)
PASS: gnu.testlet.java.text.MessageFormat.format14: number (number 1)
FAIL: gnu.testlet.java.text.MessageFormat.format14: number (number 2)
got 9999 but expected 9,999
PASS: gnu.testlet.java.text.MessageFormat.format14: number (number 3)
FAIL: gnu.testlet.java.text.MessageFormat.format14: number (number 4)
got 999,900% but expected 9,999%
PASS: gnu.testlet.java.text.MessageFormat.format14: number (number 5)
PASS: gnu.testlet.java.text.MessageFormat.format14: date (number 1)
PASS: gnu.testlet.java.text.MessageFormat.format14: date (number 2)
java.lang.IllegalArgumentException: Illegal pattern character -1
at java.text.SimpleDateFormat.formatWithAttribute
(SimpleDateFormat.java:536)
at java.text.SimpleDateFormat.format (SimpleDateFormat.java:556)
at java.text.DateFormat.format (DateFormat.java:256)
at java.text.MessageFormat.formatInternal (MessageFormat.java:473)
at java.text.MessageFormat.format (MessageFormat.java:391)
at gnu.testlet.java.text.MessageFormat.format14.testStaticFormat
(format14.java:103)
at gnu.testlet.java.text.MessageFormat.format14.test
(format14.java:48)
at gnu.testlet.SimpleTestHarness.runtest (SimpleTestHarness.java:266)
at gnu.testlet.SimpleTestHarness.main (SimpleTestHarness.java:394)
FAIL: gnu.testlet.java.text.MessageFormat.format14: date (number 3)
PASS: gnu.testlet.java.text.MessageFormat.format14: date (number 4)
PASS: gnu.testlet.java.text.MessageFormat.format14: date (number 5)
PASS: gnu.testlet.java.text.MessageFormat.format14: date (number 6)
PASS: gnu.testlet.java.text.MessageFormat.format14: time (number 1)
PASS: gnu.testlet.java.text.MessageFormat.format14: time (number 2)
java.lang.IllegalArgumentException: Illegal pattern character -1
at java.text.SimpleDateFormat.formatWithAttribute
(SimpleDateFormat.java:536)
at java.text.SimpleDateFormat.format (SimpleDateFormat.java:556)
at java.text.DateFormat.format (DateFormat.java:256)
at java.text.MessageFormat.formatInternal (MessageFormat.java:473)
at java.text.MessageFormat.format (MessageFormat.java:391)
at gnu.testlet.java.text.MessageFormat.format14.testStaticFormat
(format14.java:137)
at gnu.testlet.java.text.MessageFormat.format14.test
(format14.java:48)
at gnu.testlet.SimpleTestHarness.runtest (SimpleTestHarness.java:266)
at gnu.testlet.SimpleTestHarness.main (SimpleTestHarness.java:394)
FAIL: gnu.testlet.java.text.MessageFormat.format14: time (number 3)
PASS: gnu.testlet.java.text.MessageFormat.format14: time (number 4)
PASS: gnu.testlet.java.text.MessageFormat.format14: time (number 5)
PASS: gnu.testlet.java.text.MessageFormat.format14: time (number 6)
java.lang.IllegalArgumentException: unexpected end of text
at java.text.ChoiceFormat.applyPattern (ChoiceFormat.java:114)
at java.text.ChoiceFormat.<init> (ChoiceFormat.java:179)
at java.text.MessageFormatElement.setLocale (MessageFormat.java:143)
at java.text.MessageFormat.scanFormat (MessageFormat.java:315)
at java.text.MessageFormat.applyPattern (MessageFormat.java:336)
at java.text.MessageFormat.<init> (MessageFormat.java:577)
at java.text.MessageFormat.<init> (MessageFormat.java)
at java.text.MessageFormat.format (MessageFormat.java:388)
at gnu.testlet.java.text.MessageFormat.format14.testStaticFormat
(format14.java:163)
at gnu.testlet.java.text.MessageFormat.format14.test
(format14.java:48)
at gnu.testlet.SimpleTestHarness.runtest (SimpleTestHarness.java:266)
at gnu.testlet.SimpleTestHarness.main (SimpleTestHarness.java:394)
FAIL: gnu.testlet.java.text.MessageFormat.format14: choice (number 1)
PASS: gnu.testlet.java.text.MessageFormat.format14: miscellaneous
(number 1)
PASS: gnu.testlet.java.text.MessageFormat.format14: miscellaneous
(number 2)
PASS: gnu.testlet.java.text.MessageFormat.format14: miscellaneous
(number 3)
PASS: gnu.testlet.java.text.MessageFormat.format14: miscellaneous
(number 4)
5 of 24 tests failed
dgilbert@linux42:~/workspace/mauve> java -classpath .
gnu.testlet.SimpleTestHarness -file CurrentTests.txt -verbose -debug
gnu.testlet.java.text.MessageFormat.format14
----
PASS: gnu.testlet.java.text.MessageFormat.format14: static (String,
Object[]) (number 1)
PASS: gnu.testlet.java.text.MessageFormat.format14: static (String,
Object[]) (number 2)
PASS: gnu.testlet.java.text.MessageFormat.format14: number (number 1)
PASS: gnu.testlet.java.text.MessageFormat.format14: number (number 2)
PASS: gnu.testlet.java.text.MessageFormat.format14: number (number 3)
PASS: gnu.testlet.java.text.MessageFormat.format14: number (number 4)
PASS: gnu.testlet.java.text.MessageFormat.format14: number (number 5)
PASS: gnu.testlet.java.text.MessageFormat.format14: date (number 1)
PASS: gnu.testlet.java.text.MessageFormat.format14: date (number 2)
PASS: gnu.testlet.java.text.MessageFormat.format14: date (number 3)
PASS: gnu.testlet.java.text.MessageFormat.format14: date (number 4)
PASS: gnu.testlet.java.text.MessageFormat.format14: date (number 5)
PASS: gnu.testlet.java.text.MessageFormat.format14: date (number 6)
PASS: gnu.testlet.java.text.MessageFormat.format14: time (number 1)
PASS: gnu.testlet.java.text.MessageFormat.format14: time (number 2)
PASS: gnu.testlet.java.text.MessageFormat.format14: time (number 3)
PASS: gnu.testlet.java.text.MessageFormat.format14: time (number 4)
PASS: gnu.testlet.java.text.MessageFormat.format14: time (number 5)
PASS: gnu.testlet.java.text.MessageFormat.format14: time (number 6)
PASS: gnu.testlet.java.text.MessageFormat.format14: choice (number 1)
PASS: gnu.testlet.java.text.MessageFormat.format14: miscellaneous
(number 1)
PASS: gnu.testlet.java.text.MessageFormat.format14: miscellaneous
(number 2)
PASS: gnu.testlet.java.text.MessageFormat.format14: miscellaneous
(number 3)
PASS: gnu.testlet.java.text.MessageFormat.format14: miscellaneous
(number 4)
0 of 24 tests failed
Regards,
Dave Gilbert
http://www.jfree.org
Index: ChangeLog
===================================================================
RCS file: /cvs/mauve/mauve/ChangeLog,v
retrieving revision 1.710
diff -u -r1.710 ChangeLog
--- ChangeLog 26 Oct 2004 11:29:07 -0000 1.710
+++ ChangeLog 28 Oct 2004 10:51:44 -0000
@@ -1,3 +1,7 @@
+2004-10-28 David Gilbert <david.gilbert@object-refinery.com>
+
+ * gnu/testlet/java/net/MessageFormat/format14.java: New test.
+
2004-10-26 Michael Koch <konqueror@gmx.de>
* gnu/testlet/java/net/URLConnection/post.java:
Index: gnu/testlet/java/text/MessageFormat/format14.java
===================================================================
RCS file: gnu/testlet/java/text/MessageFormat/format14.java
diff -N gnu/testlet/java/text/MessageFormat/format14.java
--- /dev/null 1 Jan 1970 00:00:00 -0000
+++ gnu/testlet/java/text/MessageFormat/format14.java 28 Oct 2004 10:51:49 -0000
@@ -0,0 +1,206 @@
+// Tags: JDK1.4
+
+// Copyright (C) 2004 David Gilbert <david.gilbert@object-refinery.com>
+
+// Mauve is free software; you can redistribute it and/or modify
+// it under the terms of the GNU General Public License as published by
+// the Free Software Foundation; either version 2, or (at your option)
+// any later version.
+
+// Mauve is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+// GNU General Public License for more details.
+
+// You should have received a copy of the GNU General Public License
+// along with Mauve; see the file COPYING. If not, write to
+// the Free Software Foundation, 59 Temple Place - Suite 330,
+// Boston, MA 02111-1307, USA. */
+
+package gnu.testlet.java.text.MessageFormat;
+
+import gnu.testlet.TestHarness;
+import gnu.testlet.Testlet;
+
+import java.text.ChoiceFormat;
+import java.text.DateFormat;
+import java.text.DecimalFormat;
+import java.text.DecimalFormatSymbols;
+import java.text.MessageFormat;
+import java.text.NumberFormat;
+import java.text.SimpleDateFormat;
+import java.util.Date;
+import java.util.Locale;
+
+/**
+ * Some checks for the format() methods in the {@link MessageFormat} class.
+ */
+public class format14 implements Testlet
+{
+
+ /**
+ * Runs the test using the specified harness.
+ *
+ * @param harness the test harness (<code>null</code> not permitted).
+ */
+ public void test(TestHarness harness)
+ {
+ testStaticFormat(harness);
+ //testConstructor2(harness);
+ }
+
+ /**
+ * Some checks for the static format(String, Object[]) method.
+ *
+ * @param harness the test harness.
+ */
+ private void testStaticFormat(TestHarness harness)
+ {
+ harness.checkPoint("static (String, Object[])");
+
+ // basic string check
+ String s = MessageFormat.format("{0}", new Object[] {"ABC"});
+ harness.check(s, "ABC");
+
+ s = MessageFormat.format("-{0}-", new Object[] {"ABC"});
+ harness.check(s, "-ABC-");
+
+ // basic number checks
+ harness.checkPoint("number");
+ s = MessageFormat.format("{0,number}", new Object[] {new Integer(9999)});
+ String expected = NumberFormat.getInstance(Locale.getDefault()).format(9999);
+ harness.check(s, expected);
+
+ s = MessageFormat.format("{0,number,integer}", new Object[] {new Integer(9999)});
+ expected = NumberFormat.getIntegerInstance(Locale.getDefault()).format(9999);
+ harness.check(s, expected);
+
+ s = MessageFormat.format("{0,number,currency}", new Object[] {new Integer(9999)});
+ expected = NumberFormat.getCurrencyInstance(Locale.getDefault()).format(9999);
+ harness.check(s, expected);
+
+ s = MessageFormat.format("{0,number,percent}", new Object[] {new Integer(9999)});
+ expected = NumberFormat.getPercentInstance(Locale.getDefault()).format(9999);
+ harness.check(s, expected);
+
+ s = MessageFormat.format("{0,number,#,##0.00}", new Object[] {new Integer(9999)});
+ expected = new DecimalFormat("#,##0.00", new DecimalFormatSymbols(Locale.getDefault())).format(9999);
+ harness.check(s, expected);
+
+ // basic date checks
+ harness.checkPoint("date");
+ Date t = new Date();
+ s = MessageFormat.format("{0,date}", new Object[] {t});
+ expected = DateFormat.getDateInstance(DateFormat.DEFAULT, Locale.getDefault()).format(t);
+ harness.check(s, expected);
+
+ s = MessageFormat.format("{0,date,short}", new Object[] {t});
+ expected = DateFormat.getDateInstance(DateFormat.SHORT, Locale.getDefault()).format(t);
+ harness.check(s, expected);
+
+ try // don't let failure disturb remaining tests
+ {
+ s = MessageFormat.format("{0,date,medium}", new Object[] {t});
+ expected = DateFormat.getDateInstance(DateFormat.DEFAULT, Locale.getDefault()).format(t);
+ harness.check(s, expected);
+ }
+ catch (Exception e)
+ {
+ harness.debug(e);
+ harness.check(false);
+ }
+
+ s = MessageFormat.format("{0,date,long}", new Object[] {t});
+ expected = DateFormat.getDateInstance(DateFormat.LONG, Locale.getDefault()).format(t);
+ harness.check(s, expected);
+
+ s = MessageFormat.format("{0,date,full}", new Object[] {t});
+ expected = DateFormat.getDateInstance(DateFormat.FULL, Locale.getDefault()).format(t);
+ harness.check(s, expected);
+
+ s = MessageFormat.format("{0,date,dd-MMM-yyyy}", new Object[] {t});
+ expected = new SimpleDateFormat("dd-MMM-yyyy", Locale.getDefault()).format(t);
+ harness.check(s, expected);
+
+ // basic time checks
+ harness.checkPoint("time");
+ s = MessageFormat.format("{0,time}", new Object[] {t});
+ expected = DateFormat.getTimeInstance(DateFormat.DEFAULT, Locale.getDefault()).format(t);
+ harness.check(s, expected);
+
+ s = MessageFormat.format("{0,time,short}", new Object[] {t});
+ expected = DateFormat.getTimeInstance(DateFormat.SHORT, Locale.getDefault()).format(t);
+ harness.check(s, expected);
+
+ try // don't let failure disturb remaining tests
+ {
+ s = MessageFormat.format("{0,time,medium}", new Object[] {t});
+ expected = DateFormat.getTimeInstance(DateFormat.DEFAULT, Locale.getDefault()).format(t);
+ harness.check(s, expected);
+ }
+ catch (Exception e)
+ {
+ harness.debug(e);
+ harness.check(false);
+ }
+
+ s = MessageFormat.format("{0,time,long}", new Object[] {t});
+ expected = DateFormat.getTimeInstance(DateFormat.LONG, Locale.getDefault()).format(t);
+ harness.check(s, expected);
+
+ s = MessageFormat.format("{0,time,full}", new Object[] {t});
+ expected = DateFormat.getTimeInstance(DateFormat.FULL, Locale.getDefault()).format(t);
+ harness.check(s, expected);
+
+ s = MessageFormat.format("{0,time,hh:mm}", new Object[] {t});
+ expected = new SimpleDateFormat("hh:mm", Locale.getDefault()).format(t);
+ harness.check(s, expected);
+
+ harness.checkPoint("choice");
+
+ try
+ {
+ s = MessageFormat.format("{0,choice,0#zero|1#one|1>many}", new Object[]{new Double(2.0)});
+ expected = new ChoiceFormat("0#zero|1#one|1>many").format(new Double(2.0));
+ harness.check(s, expected);
+ }
+ catch (Exception e)
+ {
+ harness.debug(e);
+ harness.check(false);
+ }
+
+ harness.checkPoint("miscellaneous");
+
+ // check for null string
+ try
+ {
+ /* String s = */ MessageFormat.format(null, new Object[] {"X"});
+ harness.check(false);
+ }
+ catch (NullPointerException e)
+ {
+ harness.check(true);
+ }
+
+ // check for null array
+ s = MessageFormat.format("{0}", null);
+ harness.check(s, "{0}");
+
+ // check for null item in array
+ s = MessageFormat.format("{0}", new Object[] {null});
+ harness.check(s, "null");
+
+ // check for bad types
+ try
+ {
+ s = MessageFormat.format("{0,number}", new Object[] {"X"});
+ harness.check(false);
+ }
+ catch (IllegalArgumentException e)
+ {
+ harness.check(true);
+ }
+ }
+
+}