RE: Some issues..

[Mark Wielaard <mark at klomp dot org>]

Hi,

On Fri, 2004-04-23 at 11:11, Jeroen Frijters wrote:
> Mark Wielaard wrote:
> > On Fri, 2004-04-16 at 14:03, Andrew Haley wrote:
> > > Mark Wielaard writes:
> > >  > Ehe, how do you use/invoke it?
> > > 
> > > It gets invoked automatically when you run Mauve, at least on my
> > > system.  BinaryCompatibilityTest.java is the driver that invokes it.
> > 
> > Aha. And it uses Runtime.exec()... Which wasn't properly 
> > implemented in GNU Classpath proper. But we have it now (almost)!
> > 
> > ow that I can run it I see that kaffe, jamvm and gij all fail most of
> > the tests. Each of IL bin_01 till IL bin_18 fails 5 or 6 times giving:
> > 107 of 125 tests failed
> 
> I never really payed attention to this test, but now I see that it is
> *nix specific (using shell script <shiver>).
> 
> What is the policy for Mauve? I realise most of you don't care about/for
> Windows, but personally I do. So I support Mark's earlier
> suggestion/request to move this to a separate section.

There is always Cygwin <http://cygwin.com/>
But I do think it might be better to separate out this test from the
rest of Mauve proper. On the other hand, if you have a non-GNUish/Posix
system then you can always disable this one test. Separating it out
without a mechanism for running the tests on multiple systems isn't
really worth it I guess.

> On a somewhat related note, the invalid_port test in DatagramSocketTest2
> assumes that it is illegal to create a DatagramSocket that listens on
> port 21, but I don't believe that is part of the Java specification.

I believe you are right. It is only an issue for processes without
enough privileges on some systems (which normally reserve all post
between 0 and 1024 for "system" services). So I committed this patch:

2004-04-25  Mark Wielaard  <mark@klomp.org>

       * gnu/testlet/java/net/DatagramSocket/DatagramSocketTest2.java: Remove
       RESERVED_PORT (21) test.

Cheers,

Mark

Index: gnu/testlet/java/net/DatagramSocket/DatagramSocketTest2.java
===================================================================
RCS file: /cvs/mauve/mauve/gnu/testlet/java/net/DatagramSocket/DatagramSocketTest2.java,v
retrieving revision 1.5
diff -u -r1.5 DatagramSocketTest2.java
--- gnu/testlet/java/net/DatagramSocket/DatagramSocketTest2.java	29 Oct 2003 14:39:20 -0000	1.5
+++ gnu/testlet/java/net/DatagramSocket/DatagramSocketTest2.java	25 Apr 2004 11:08:51 -0000
@@ -59,7 +59,6 @@
 {
 	final static int INVALID_PORT = -1;
 	final static int ECHO_PORT = 7;
-	final static int RESERVED_PORT = 21;
 	final static int GOOD_PORT = 37777;
 	final static int MAX_PORT = 65535;
 
@@ -93,25 +92,6 @@
 	public void invalid_port()
 	{
 		harness.checkPoint("invalid_port");
-		try
-		{
-			DatagramSocket sock = new DatagramSocket(RESERVED_PORT);
-			errormsg("invalid_port", 1, true, "BindException");
-		}
-		catch (BindException e)
-		{
-			harness.check(true);
-		}
-		catch (SocketException e)
-		{
-			errormsg("invalid_port", 1, false, "SocketException");
-		}
-		catch (NullPointerException e)
-		{
-			errormsg("invalid_port", 1, false, "NullPointerException");
-			e.printStackTrace();
-		}
-
 		try
 		{
 			DatagramSocket sock = new DatagramSocket(INVALID_PORT);

Attachment: signature.asc
Description: This is a digitally signed message part