This is the mail archive of the
lvm2-cvs@sourceware.org
mailing list for the LVM2 project.
LVM2/tools lvcreate.c
- From: zkabelac at sourceware dot org
- To: lvm-devel at redhat dot com, lvm2-cvs at sourceware dot org
- Date: 10 Nov 2011 12:40:29 -0000
- Subject: LVM2/tools lvcreate.c
CVSROOT: /cvs/lvm2
Module name: LVM2
Changes by: zkabelac@sourceware.org 2011-11-10 12:40:29
Modified files:
tools : lvcreate.c
Log message:
Thin move _read_activation_params check
Since we finaly recognize thin creation only after
_determine_snapshot_type() - move _read_activation_params()
after it - so we can support lvcreate -an thin snapshot.
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/lvcreate.c.diff?cvsroot=lvm2&r1=1.248&r2=1.249
--- LVM2/tools/lvcreate.c 2011/11/10 12:39:46 1.248
+++ LVM2/tools/lvcreate.c 2011/11/10 12:40:29 1.249
@@ -789,9 +789,6 @@
return 0;
}
- if (!_read_activation_params(lp, cmd))
- return_0;
-
/*
* Allocation parameters
*/
@@ -993,6 +990,15 @@
goto_out;
}
+ /*
+ * Check activation parameters to support inactive thin snapshot creation
+ * FIXME: anything else needs to be moved past _determine_snapshot_type()?
+ */
+ if (!_read_activation_params(&lp, cmd)) {
+ r = ECMD_FAILED;
+ goto_out;
+ }
+
if (!_update_extents_params(vg, &lp, &lcp)) {
r = ECMD_FAILED;
goto_out;