This is the mail archive of the
libffi-discuss@sourceware.org
mailing list for the libffi project.
Re: libffi is broken for x32
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Richard Henderson <rth at redhat dot com>
- Cc: Anthony Green <green at moxielogic dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>, libffi-discuss at sourceware dot org
- Date: Mon, 12 Jan 2015 16:57:00 -0800
- Subject: Re: libffi is broken for x32
- Authentication-results: sourceware.org; auth=none
- References: <CAMe9rOpTqX-d+CoSnxqug__gYv1HVZ8+6-KBqQ8fWo9+sH07Cg at mail dot gmail dot com> <CAMe9rOp5jCwZ548gNjdO7S6MenRLM1W-5q-KDOFOzuKhb_Zt=Q at mail dot gmail dot com> <54B466EE dot 70204 at redhat dot com>
On Mon, Jan 12, 2015 at 4:29 PM, Richard Henderson <rth@redhat.com> wrote:
> On 01/12/2015 03:46 PM, H.J. Lu wrote:
>> On Mon, Jan 12, 2015 at 2:42 PM, H.J. Lu <hjl.tools@gmail.com> wrote:
>>> This libffi commit:
>>>
>>> 13e2d7b92557a9511a0414df82bf2df3edc55cba is the first bad commit
>>> commit 13e2d7b92557a9511a0414df82bf2df3edc55cba
>>> Author: Anthony Green <green@moxielogic.com>
>>> Date: Thu Jan 10 10:52:02 2013 -0500
>>>
>>> Handle both 32 and 64-bit x86 builds regardless of target triple
>>>
>>> breaks x32.
>>>
>>
>> This patch passed "make check" in libffi on x32. I am testing
>> it in GCC now.
>>
>> GCC is configured as x86_64-unknown-linux-gnu with x32
>> enabled. libffi should set TARGET to X86_64 if __x86_64__
>> is defined.
>
> I thought the target for that was x86_64-*-linux-gnux32?
>
> There's not usually an x32 multilib for "plain" 64-bit, so
> I wonder how you're configuring?
>
The problem is my x86_64-*-linux-gnux32 patch
https://gcc.gnu.org/ml/gcc-patches/2012-08/msg01083.html
was never accepted upstream. Can I apply it to config.guess
in GCC?
--
H.J.