This is the mail archive of the libffi-discuss@sourceware.org mailing list for the libffi project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch AArch64] Add missing .note.GNU-stack note


On Fri, Nov 21, 2014 at 05:30:36PM +0000, James Greenhalgh wrote:
> *ping*

*ping^2*

Cheers,
James

> 
> Thanks,
> James
> 
> On Thu, Nov 13, 2014 at 03:32:02PM +0000, James Greenhalgh wrote:
> > 
> > Hi Anthony,
> > 
> > This trivial patch fixes:
> >   https://github.com/atgreen/libffi/issues/141
> > 
> > By adding a .note.GNU-stack note to the bottom of src/aarch64/sysv.S.
> > 
> > Tested native on aarch64-none-linux-gnu, with no issues in the testsuite.
> > 
> > Could you please apply this to HEAD?
> > 
> > Thanks,
> > James
> > 
> > ---
> > 
> > 2014-11-13  James Greenhalgh  <james.greenhalgh@arm.com>
> > 
> > 	* aarch64/sysv.S: Add .note.GNU-stack.
> > 
> 
> > diff --git a/src/aarch64/sysv.S b/src/aarch64/sysv.S
> > index 1fb68f2..d5b1c2e 100644
> > --- a/src/aarch64/sysv.S
> > +++ b/src/aarch64/sysv.S
> > @@ -396,3 +396,7 @@ CNAME(ffi_go_closure_SYSV):
> >  	.size	CNAME(ffi_go_closure_SYSV), . - CNAME(ffi_go_closure_SYSV)
> >  #endif
> >  #endif /* FFI_GO_CLOSURES */
> > +
> > +#if defined __ELF__ && defined __linux__
> > +	.section	.note.GNU-stack,"",%progbits
> > +#endif
> 
> 


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]