This is the mail archive of the libffi-discuss@sourceware.org mailing list for the libffi project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFC] Proposal for m*vc build issue (#138)


About GCC and --std==c99

I noticed dlmalloc.c that ships with libffi contains #if defined (__GNUC__) && defined(i386)

This really should be #if defined (__GNUC__) && defined(__i386__) because when compiling with -std=c99, i386 is not defined whereas __i386__ is.

Gregory
________________________________________
From: libffi-discuss-owner@sourceware.org <libffi-discuss-owner@sourceware.org> on behalf of Dominik Vogt <vogt@linux.vnet.ibm.com>
Sent: Wednesday, November 12, 2014 2:35 PM
To: libffi-discuss@sourceware.org
Subject: Re: [RFC] Proposal for m*vc build issue (#138)

On Wed, Nov 12, 2014 at 02:26:24PM +0100, Dominik Vogt wrote:
> On Wed, Nov 12, 2014 at 02:16:27PM +0100, Richard Henderson wrote:
> > > It might be good to
> > > specifically double check the detection of a compiler with complex
> > > support using macros.
> >
> > Looks good to me.
>
> ... but doesn't work with the gcc I use.  I'll check what's going
> on.  Maybe the no-complex case should generate a warning.

Hm, my gcc does not define __STDC_VERSION__ unless called
specifically with --std=c99 (or maybe other settings too that I did
not check).  So the test always thinks that complex types are not
available.

Ciao

Dominik ^_^  ^_^

--

Dominik Vogt
IBM Germany


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]