This is the mail archive of the libffi-discuss@sourceware.org mailing list for the libffi project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Fix powerpc breakage from 6e8a4460


On Mon, Nov 10, 2014 at 02:54:42PM +1030, Alan Modra wrote:
> The addition of FFI_TYPE_COMPLEX broke powerpc libffi, showing up as
> four testsuite failures on powerpc64le.  This fixes the breakage and
> ensures a more spectacular set of failures if something like this
> happens again.
> 
> 	* src/powerpc/ffitarget.h: #error on unexpected FFI_TYPE_LAST.
...
> +/* ppc_closure.S and linux64_closure.S expect this.  */
> +#define FFI_PPC_TYPE_LAST FFI_TYPE_POINTER
> +
> +/* We define additional types below.  If generic types are added that
> +   must be supported by powerpc libffi then it is likely that
> +   FFI_PPC_TYPE_LAST needs increasing *and* the jump tables in
> +   ppc_closure.S and linux64_closure.S be extended.  */

Does this affect only powerpc?  Is there any risk of breaking other
platforms too?

Ciao

Dominik ^_^  ^_^

-- 

Dominik Vogt
IBM Germany


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]