This is the mail archive of the
libffi-discuss@sourceware.org
mailing list for the libffi project.
Re: libffi 3.1-rc1 needs testing!
- From: Anthony Green <green at moxielogic dot com>
- To: James Greenhalgh <james dot greenhalgh at arm dot com>
- Cc: "libffi-discuss\ at sourceware dot org" <libffi-discuss at sourceware dot org>
- Date: Fri, 28 Mar 2014 13:33:22 -0400
- Subject: Re: libffi 3.1-rc1 needs testing!
- Authentication-results: sourceware.org; auth=none
- References: <87eh2liiow dot fsf at moxielogic dot com> <87a9ce3ry7 dot fsf at moxielogic dot com> <20140328150533 dot GA31475 at arm dot com>
James Greenhalgh <james.greenhalgh@arm.com> writes:
> Hi,
>
> I'm seeing issues with libffi.call/float2.c on GCC 4.9 toolchains across
> ARM, AArch64, x86_64. I guess GCC 4.9 is more aggressive in warning for
> unused values:
Thanks James. I just committed a fix for this.
AG
>
> FAIL: libffi.call/float2.c -W -Wall -O0 (test for excess errors)
> FAIL: libffi.call/float2.c -W -Wall -O2 (test for excess errors)
> FAIL: libffi.call/float2.c -W -Wall -O3 (test for excess errors)
> FAIL: libffi.call/float2.c -W -Wall -Os (test for excess errors)
> FAIL: libffi.call/float2.c -W -Wall -O2 -fomit-frame-pointer (test for excess errors)
>
> In file included from ../../testsuite/libffi.call/float2.c:10:0:
> ../../testsuite/libffi.call/float2.c: In function 'main':
> ../../testsuite/libffi.call/ffitest.h:18:39: warning: right-hand operand of comma expression has no effect [-Wunused-value]
> #define CHECK(x) (!(x) ? (abort(), 1) : 0)
> ^
> ../../testsuite/libffi.call/float2.c:55:5: note: in expansion of macro 'CHECK'
> CHECK(0);
> ^
> output is:
> In file included from ../../testsuite/libffi.call/float2.c:10:0:
> ../../testsuite/libffi.call/float2.c: In function 'main':
> ../../testsuite/libffi.call/ffitest.h:18:39: warning: right-hand operand of comma expression has no effect [-Wunused-value]
> #define CHECK(x) (!(x) ? (abort(), 1) : 0)
> ^
> ../../testsuite/libffi.call/float2.c:55:5: note: in expansion of macro 'CHECK'
> CHECK(0);
> ^
>
> Thanks,
> James