This is the mail archive of the libffi-discuss@sourceware.org mailing list for the libffi project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Use $CFLAGS to calculate multi_os_directory in configure.ac.


On 03/03/14 14:38, Samuli Suominen wrote:
> On 03/03/14 14:36, Dominik Vogt wrote:
>> configure.ac forgets to use $CFLAGS when running
>>
>>   $CC -print-multi-os-directory
>>
>> This may result in a bad installation path for the library (on
>> s390 I get ..../lib/../lib64 instead of just ..../lib" as it should
>> be).  The attached patch fixes that (configure needs to be
>> regenerated.)
>>
>> Ciao
>>
>> Dominik ^_^  ^_^
>>
> Since we are on the /topic of -print-multi-os-directory and it's use in
> libffi, I'd like to point out the concept is broken:
>
> http://bugs.gentoo.org/show_bug.cgi?id=462814
>
> It's in direct conflict with the use of --libdir= and is not flexible
> enough to be used in packages like this.
>
> What really should be done, is revert the patch that ever introduced the
> use of -print-multi-os-directory for determining
> the installation directory, or at the very least, force it to respect
> --libdir=, not override --libdir=
>
> - Samuli

So, we ended up using a hack like...

sed -i 's:@toolexeclibdir@:$(libdir):g' Makefile.in

...to package libffi, but I don't agree forcing the use of `sed` is a
good prereq for configuring a package
to respect the users, systems, wishes


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]