This is the mail archive of the
libffi-discuss@sourceware.org
mailing list for the libffi project.
RE: [libffi testsuite] Set -ffp-contract=off for libffi.call/many.c
- From: "James Greenhalgh" <james dot greenhalgh at arm dot com>
- To: "James Greenhalgh" <James dot Greenhalgh at arm dot com>, "'Anthony Green'" <green at moxielogic dot com>
- Cc: <libffi-discuss at sourceware dot org>, "Marcus Shawcroft" <Marcus dot Shawcroft at arm dot com>
- Date: Tue, 25 Jun 2013 13:54:55 +0100
- Subject: RE: [libffi testsuite] Set -ffp-contract=off for libffi.call/many.c
- References: <1365413805-5517-1-git-send-email-james dot greenhalgh at arm dot com> <CACxje5_Tp0an2rRwyUWKsqdE9vMOwDxfkSgGYTiankAH0bQLFQ at mail dot gmail dot com> <009101ce5c48$0c657720$25306560$ at greenhalgh@arm.com>
Hi Anthony,
Any thoughts on this?
Regards,
James
> > The problem with unqualified dg-options is that non-GCC compilers
> > will complain about them, and libffi currently supports compilers
> from
> > IBM, Oracle and Microsoft. Could you please resubmit with the
> > appropriate target qualifier? Just look at other uses of dg-options.
> > (to answer your other question, either a patch email or pull request
> > would be fine)
>
> Hi Anthony,
>
> I'm sorry, but I'm not sure what you are asking me to do. Looking at
> other test cases I see, for example:
>
> testsuite/libffi.call/huge_struct.c:/* { dg-options -Wformat=0 { target
moxie*-*-elf } } */
>
> But my understanding is that this restricts adding the option to
> moxie*-*-elf targets rather than compilers.
>
> I think to implement what you are asking I would want something like
>
> /* { dg-options -ffp-contract=off { compiler *gcc* } } */
>
> As best as I understand it, any GCC target which can contract
> fused multiply adds will require this change, which would require
> me to write:
>
> /* { dg-options -ffp-contract=off { target *-*-* } } */
>
> But then I think I have opened myself up to failing with other
> compilers
> again.
>
> Have I completely misunderstood what you are requesting? Could you
> point me towards some other examples which achieve what I want?
>
> Thanks,
> James