This is the mail archive of the libffi-discuss@sourceware.org mailing list for the libffi project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

[PATCH]: Small patch for libffi.call/err_bad_abi.c libffi failures on s390

From: Uros Bizjak <ubizjak at gmail dot com>
To: libffi-discuss at sourceware dot org
Cc: Andreas Krebbel <krebbel at linux dot vnet dot ibm dot com>
Date: Wed, 1 Aug 2012 22:44:00 +0200
Subject: [PATCH]: Small patch for libffi.call/err_bad_abi.c libffi failures on s390

Hello!

I have noticed that s390 fails a couple of libffi failures [1]:

FAIL: libffi.call/err_bad_abi.c -O0 -W -Wall execution test
FAIL: libffi.call/err_bad_abi.c -O2 execution test
FAIL: libffi.call/err_bad_abi.c -O3 execution test
FAIL: libffi.call/err_bad_abi.c -Os execution test
FAIL: libffi.call/err_bad_abi.c -O2 -fomit-frame-pointer execution test

These failures should be fixed by following patch, in the same way as
other targets:

2012-08-01  Uros Bizjak  <ubizjak@gmail.com>

	* src/s390/ffi.c (ffi_prep_closure_loc): Don't ASSERT ABI test,
	just return FFI_BAD_ABI when things are wrong.

Untested (for obvious reasons), but should be trivially correct.

[1] http://gcc.gnu.org/ml/gcc-testresults/2012-08/msg00082.html

Uros.

Attachment: l.diff.txt
Description: Text document

Follow-Ups:
- Re: [PATCH]: Small patch for libffi.call/err_bad_abi.c libffi failures on s390
  - From: Ulrich Weigand

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]