Re: libffi doesn't keep the stack aligned to 16 bytes

[Anthony Green <green at redhat dot com>]

Neil Roberts <neil@linux.intel.com> writes:

> I wasn't subscribed to this list so I didn't see the replies to my
> email. Sorry about that. It looks like the patch has now been applied
> which is great, thanks. Just a small complaint however that I think a
> lot of contributors would appreciate it if you could retain the commit
> message and authorship when merging patches to git master instead of
> combining them all into one commit.

Here's how my workflow goes...

libffi patches go in either the GCC SVN tree via the GCC hackers, or
into the libffi git tree by me.  Patches that go into the libffi GIT
tree are managed with quilt.  This lets me easily un-apply all of the
patches and rebase from the GCC SVN tree.  This re-basing happens on an
ad-hoc basis.  Conversely, the libffi GIT tree patches are periodically
merged, one by one, into the GCC tree.

Your patch was committed to the GCC SVN tree by Andrew Haley and entered
libffi GIT through rebasing.  Given my current work flow, I don't see
how I can mangle the GIT commit records to show your contribution.  On
the other hand, the ChangeLog file definitely does show your
contribution.

There may be some simple change to my workflow that will give you want
you want, but I don't know what it is yet.  My git skills are pretty
limited.  Suggestions?

AG