This is the mail archive of the
libffi-discuss@sourceware.org
mailing list for the libffi project.
Re: [PATCH] don't count return value space twice on x86
Dan Witte <dwitte@mozilla.com> writes:
> Anthony,
>
> There's a bug in stdcall x86 WIN32 closure code where stack space for the return value is counted twice -- which leads to overpopping and a spectacular crash. This adds an X86_ANY define for all x86 plats, which simplifies logic and means that stack computation is done consistently in the x86 prep_cif_machdep, rather than double-counted by prep_cif.
>
> Look OK?
Yes, thanks - applied.
AG
>
> Cheers,
> Dan.