This is the mail archive of the libffi-discuss@sourceware.org mailing list for the libffi project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: libffi 3.0.9rc6


On 26.12.09 13:37, Anthony Green wrote:
On 12/26/2009 06:50 AM, Andreas Tobler wrote:
On 26.12.09 11:11, Andreas Schwab wrote:
Andreas Tobler<andreast-list@fgznet.ch> writes:

This huge_struct test fails under powerpc-*-linux

See<http://sourceware.org/ml/libffi-discuss/2009/msg00337.html> and <http://sourceware.org/ml/libffi-discuss/2009/msg00360.html>.

Thank you Andreas!


With the patch mentioned above the FreeBSD and Linux PowerPC port pass
w/o failure.

Additionally, if I apply the attached diff, I also pass the
huge_struct test case on i386-pc-solaris2.11 and sparc-sun-solaris2.10
(It also passes on all other archs here.)

The issue is this, the %p modifier for printf under solaris does not
add a leading 0x. So I modified the test case to use %#x and cast the
value to (unsigned int). Do you think this feasible?

Thanks,
Andreas


I had to change it to %#lx and (unsigned long) on x86-64 linux to make it compile cleanly. See the attached patch. I can test on a bunch of linux systems now (x86-64, powerpc, armv5tel, etc). If you can check Solaris and *bsd, then I think we have a winner.

Thank you!


amd64-unknown-freebsd9.0: ok
i386-pc-solaris2.11: ok
i386-unknown-freebsd9.0: ok
i686-apple-darwin9.8.0: ok
powerpc-apple-darwin9.8.0 failures see: (PR42378/PR34311)
powerpc-redhat-linux-gnu: ok
powerpc-unknown-freebsd9.0: ok
sparc-sun-solaris2.10: ok
(I'll add them to the wiki.)

And, another new target:)
Here it is upon you if you like to add it to 3.0.9. It is a bit boring here so I thought to try this one as well ;)


amd64-unknown-openbsd4.6

With these two patches (configure.ac & configure and testsuite/lib/libffi-dg.exp):

--- configure.ac.orig	2009-12-26 15:10:45.000000000 +0100
+++ configure.ac	2009-12-26 15:23:05.000000000 +0100
@@ -51,14 +51,10 @@
 	TARGET=ARM; TARGETDIR=arm
 	;;

-  amd64-*-freebsd*)
+  amd64-*-freebsd* | amd64-*-openbsd*)
 	TARGET=X86_64; TARGETDIR=x86
   	;;

-  amd64-*-freebsd*)
-	TARGET=X86_64; TARGETDIR=x86
-	;;
-
   avr32*-*-*)
 	TARGET=AVR32; TARGETDIR=avr32
 	;;

--- testsuite/lib/libffi-dg.exp.orig	2009-12-26 15:11:04.000000000 +0100
+++ testsuite/lib/libffi-dg.exp	2009-12-26 15:12:10.000000000 +0100
@@ -197,6 +197,10 @@
 	lappend options "libs= -shared-libgcc"
     }

+    if { [string match "*-*-openbsd*" $target_triplet] } {
+	lappend options "libs= -lpthread"
+    }
+
     lappend options "libs= -lffi"

verbose "options: $options"



Regards,
Andreas


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]