This is the mail archive of the
libffi-discuss@sources.redhat.com
mailing list for the libffi project.
Re: your patch broke darwin libffi
- From: Bryce McKinlay <bryce at waitaki dot otago dot ac dot nz>
- To: David Edelsohn <dje at watson dot ibm dot com>
- Cc: Andreas Tobler <toa at pop dot agri dot ch>, gcc-patches at gcc dot gnu dot org, libffi-discuss at sources dot redhat dot com
- Date: Sat, 19 Jan 2002 13:46:56 +1300
- Subject: Re: your patch broke darwin libffi
- References: <200201181628.LAA29338@makai.watson.ibm.com>
David Edelsohn wrote:
> The following patch should get rid of the Darwin link error.
>ffi_call_DARWIN is not defined for AIX either, and it does not complain.
>Given the delicacy of AIX in this area, I did not expect Darwin to have a
>problem with the missing symbol if AIX was satisfied.
>
> * src/powerpc/darwin.S (_ffi_call_AIX): New.
>
>! /* Provide a null definition of _ffi_call_AIX. */
>! .text
>! .align 2
>! .globl _ffi_call_AIX
>! .text
>! .align 2
>! _ffi_call_AIX:
>! blr
>! //END(_ffi_call_AIX)
>
>
Wouldn't it be better to give this function the same name in both aix.S
and darwin.S, since only one of them gets built?
regards
Bryce.