This is the mail archive of the
libc-ports@sources.redhat.com
mailing list for the libc-ports project.
Re: [PATCH] aarch64: Enable ifunc support.
- From: "Carlos O'Donell" <carlos at redhat dot com>
- To: Will Newton <will dot newton at linaro dot org>
- Cc: "libc-ports at sourceware dot org" <libc-ports at sourceware dot org>, Patch Tracking <patches at linaro dot org>
- Date: Tue, 26 Nov 2013 11:25:46 -0500
- Subject: Re: [PATCH] aarch64: Enable ifunc support.
- Authentication-results: sourceware.org; auth=none
- References: <5294628E dot 30507 at linaro dot org> <5294BD18 dot 40507 at redhat dot com> <CANu=Dmg+sAXq3+YThqonG-DsPEdpBnASA4uLWX26qBj76q_RkA at mail dot gmail dot com>
On 11/26/2013 10:39 AM, Will Newton wrote:
> On 26 November 2013 15:24, Carlos O'Donell <carlos@redhat.com> wrote:
>> On 11/26/2013 03:57 AM, Will Newton wrote:
>>>
>>> Add support for handling the R_AARCH64_IRELATIVE relocation and
>>> STT_GNU_IFUNC symbols to the aarch64 port.
>>
>> How did you test this?
>
> Running the glibc testsuite - which is actually a pretty good test for
> the ifunc code. There's no functionality in the aarch64 port yet that
> actually uses this yet so I couldn't test that. The only screw up that
> the testsuite does not find is failing to pass hwcap correctly to the
> resover, but I pretty intensively stared at that code and seen as
> everything goes through elf_ifunc_invoke I am happy that it should
> work in practice.
Perfect, then I'm happy with the patch.
If Marcus is happy then I think you get to check this in.
Cheers,
Carlos.