This is the mail archive of the
libc-ports@sources.redhat.com
mailing list for the libc-ports project.
RE: [PATCH] 2nd round of Mips ifunc support
- From: Jack Carter <Jack dot Carter at imgtec dot com>
- To: Will Newton <will dot newton at linaro dot org>
- Cc: "libc-ports at sourceware dot org" <libc-ports at sourceware dot org>, "rdsandiford at googlemail dot com" <rdsandiford at googlemail dot com>
- Date: Wed, 20 Nov 2013 19:56:21 +0000
- Subject: RE: [PATCH] 2nd round of Mips ifunc support
- Authentication-results: sourceware.org; auth=none
- References: <4CEFBC1BE64A8048869F799EF2D2EEEE4C516140 at BADAG02 dot ba dot imgtec dot org>,<CANu=DmhpLyPf0H+XeSMp6OBYmTrsybh=U6D64pqz8nfQ-zKxyA at mail dot gmail dot com>
Will, Thanks for looking at this. My responses are below.
Jack
________________________________________
> From: Will Newton [will.newton@linaro.org]
> Sent: Saturday, November 16, 2013 3:06 AM
> To: Jack Carter
> Cc: libc-ports@sourceware.org; rdsandiford@googlemail.com
> Subject: Re: [PATCH] 2nd round of Mips ifunc support
>
> On 16 November 2013 00:41, Jack Carter <Jack.Carter@imgtec.com> wrote:
> > Attached is the second pass for Mips ifunc support in glibc.
> >
> > There is an abi attached as well.
>
> Your patch would be easier to review if it was posted inline with e.g.
> git-send-email.
Will do. I got reamed for using it for LLVM, but am learning the differences between
the 2 cultures.
>
> I don't think the vxworks comment in the commit message (or indeed the
> reference to micromips etc.) makes any sense in the context of glibc.
I will take them out.
>
> The use of __builtin_expect should be replaced with __glibc_unlikely.
I will make the changes.
>
> The example in your ABI doc should probably take an argument of the
> hwcap value rather than void.
I will make the changes.
>
> --
> Will Newton
> Toolchain Working Group, Linaro