This is the mail archive of the
libc-ports@sources.redhat.com
mailing list for the libc-ports project.
Re: [PATCH] MIPS: Use sqrt instruction on mips32 and mips64.
- From: "Joseph S. Myers" <joseph at codesourcery dot com>
- To: Steve Ellcey <sellcey at mips dot com>
- Cc: <libc-ports at sourceware dot org>
- Date: Thu, 3 Oct 2013 19:34:33 +0000
- Subject: Re: [PATCH] MIPS: Use sqrt instruction on mips32 and mips64.
- Authentication-results: sourceware.org; auth=none
- References: <5846cd67-3ec4-4b51-b6e2-3d50d044cbc1 at BAMAIL02 dot ba dot imgtec dot org>
On Thu, 3 Oct 2013, Steve Ellcey wrote:
> This is a fix for PR 15632. The mips32 and mips64 glibc builds are not
> using the sqrt instruction in the sqrt libm functions. Each of the new files
> is a single line to include mips/fpu/e_sqrt.c (or e_sqrtf.c). I initially
> tried to create mips64/fpu but that did not work so I had to create both
> mips64/n32/fpu and mips64/n64/fpu instead.
>
> I did not see any sqrt tests in the glibc performance benchmarks, so I just
> ran a test of my own that did a bunch of sqrt operations and compiled it
> with -O2 -fno-builtins. It went from 61 seconds to 17 seconds on my 74k
> board.
>
> I also ran the glibc testsuite with the o32, n32, and n64 ABI's to verify
> there were no regressions in the testsuite.
>
> Ok to checkin?
OK (with of course [BZ #15632] in the ChangeLog.mips entry, and that bug
number added to the list of fixed bugs in the NEWS file). It would be a
good idea to add an architecture-independent sqrt performance test,
though.
--
Joseph S. Myers
joseph@codesourcery.com