This is the mail archive of the
libc-ports@sources.redhat.com
mailing list for the libc-ports project.
Re: [PATCH roland/arm-strlen] Make armv6t2 strlen work in ARM mode too.
- From: "Joseph S. Myers" <joseph at codesourcery dot com>
- To: Roland McGrath <roland at hack dot frob dot com>
- Cc: <libc-ports at sourceware dot org>
- Date: Fri, 30 Aug 2013 20:36:42 +0000
- Subject: Re: [PATCH roland/arm-strlen] Make armv6t2 strlen work in ARM mode too.
- Authentication-results: sourceware.org; auth=none
- References: <20130830180620 dot 77DD12C072 at topped-with-meat dot com>
On Fri, 30 Aug 2013, Roland McGrath wrote:
> I tested that this has no effect (assembled code wholly unchanged) on
> arm-linux-gnueabihf. I tested that the ARM-mode support actually works by
> hacking in "#define NO_THUMB" at the top and verifying no failures from
> 'make check subdirs=string'.
>
> Incidentally, assembly writers really ought to write more comments! For
> example, I deduced the only plausible reason for using an explicit bne.w
> and added a comment about it, but it is exactly the sort of non-obvious
> subtle microoptimization that desperately needed clear comments in the
> first place.
>
>
> OK for trunk?
OK.
--
Joseph S. Myers
joseph@codesourcery.com