Re: [PATCH] tile: improve detection for missing -mcmodel=large support

[David Miller <davem at davemloft dot net>]

From: Chris Metcalf <cmetcalf@tilera.com>
Date: Thu, 6 Jun 2013 16:10:49 -0400

> Ping! for David Miller.

This is fine to backport to 2.17, thanks.

> On 5/28/2013 2:37 PM, Chris Metcalf wrote:
>> I pushed this to master.  "Ping" for David Miller to comment on 2.17 acceptability.  Thanks!
>>
>> On 5/23/2013 10:05 PM, Chris Metcalf wrote:
>>> (Adding David explicitly to Cc.)
>>>
>>> On 5/23/2013 6:17 PM, Carlos O'Donell wrote:
>>>> On 05/23/2013 03:20 PM, Chris Metcalf wrote:
>>>>> The existing test avoided passing -mcmodel=large if the compiler didn't
>>>>> support it.  However, we need to test not just the compiler support, but
>>>>> also the toolchain (as and ld) support, so make the test more complete.
>>>>> In addition, we have to avoid using the hwN_plt() assembly operators if
>>>>> that support is missing, so guard the uses with #ifdef NO_PLT_PCREL.
>>>>>
>>>>> This allows us to properly build glibc with the current community
>>>>> binutils, which doesn't yet have the PC-relative PLT operator support.
>>>>> The -mcmodel=large support is in gcc 4.8, but the toolchain support
>>>>> won't be present in the community until binutils 2.24.
>>>>> ---
>>>>> This change should also be applied on the 2.17 release branch for
>>>>> when we release a 2.17.1.
>>>> No, just backport it immediately after checkin to master. The 2.17
>>>> branch *is* 2.17.1 in development and when we get enough changes in
>>>> that branch we cut it and make a 2.17.1 release.
>>>>
>>>> You need release manager ACK though, which is David Miller. We normally
>>>> handle backports via bugzilla bugs with keyword glibc_2.17, but it
>>>> can be less formal if you just CC David and ask for ACK.
>>> David, is it OK if I backport this to the 2.17 branch after I commit?  Do you want a BZ# to track it?