This is the mail archive of the
libc-ports@sources.redhat.com
mailing list for the libc-ports project.
Re: [PATCH roland/arm-memcpy] ARM: Make multiarch memcpy always use NEON when compiler does
- From: Richard Henderson <rth at twiddle dot net>
- To: Roland McGrath <roland at hack dot frob dot com>
- Cc: libc-ports at sourceware dot org
- Date: Tue, 14 May 2013 08:47:39 -0700
- Subject: Re: [PATCH roland/arm-memcpy] ARM: Make multiarch memcpy always use NEON when compiler does
- References: <20130513224722 dot 9F17C2C05E at topped-with-meat dot com>
On 05/13/2013 03:47 PM, Roland McGrath wrote:
> IFUNC_IMPL (i, name, memcpy,
> IFUNC_IMPL_ADD (array, i, memcpy, hwcap & HWCAP_ARM_NEON,
> - __memcpy_neon)
> +#ifdef __ARM_NEON__
> + memcpy
> +#else
> + __memcpy_neon
> +#endif
> + )
> +#ifndef __ARM_NEON__
> IFUNC_IMPL_ADD (array, i, memcpy, hwcap & HWCAP_ARM_VFP,
> __memcpy_vfp)
> +#endif
> IFUNC_IMPL_ADD (array, i, memcpy, 1, __memcpy_arm));
I think you're better off leaving the __memcpy_neon symbol in all cases.
Having memcpy be an alias to __memcpy_neon would make the rest of the patch
simpler.
r~