This is the mail archive of the libc-ports@sources.redhat.com mailing list for the libc-ports project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH roland/arm-avoid-r9] ARM: Use r10 instead of r9.


On Thu, 28 Feb 2013, Roland McGrath wrote:

> > looks like it should be r5-r8, r10.  How was this patch tested?
> 
> Oops, I caught most of those cases but missed the last couple.
> Now fixed on the branch.
> 
> I haven't done any testing at all yet.  I wanted to make sure you didn't
> have some broader objection to the change before I dealt with getting set
> up to do arm-linux-gnueabi builds and test runs.  If you're not willing to
> approve on eyeball validation alone (which is eminently reasonable, of
> course), then I'll get my testing setup in order before asking again.

I think the principle is fine, but this does need testing as illustrated 
by the above issue.  (Unlike Richard's whole new implementations of some 
string functions, I don't think there's any need for big-endian testing 
here; testing for just one endianness suffices.)

-- 
Joseph S. Myers
joseph@codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]