This is the mail archive of the libc-ports@sources.redhat.com mailing list for the libc-ports project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 05/26] arm: Introduce thumb helpers s and pc_ofs


On 2013-02-27 16:20, Joseph S. Myers wrote:
* sysdeps/arm/sysdep.h (s, pc_ofs): New macros.
Other assembler syntax macros have names in uppercase, and a single
character seems too short for a macro name to me.


I simply found that "s(and)" is easy to read, and it looks close to "ands" to which it expands. I'd rather drop this change, and all uses thereof, than make the code less readable.



r~



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]