This is the mail archive of the libc-ports@sources.redhat.com mailing list for the libc-ports project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] AArch64 rename .x file to .c

Hi!

On Tue, 20 Nov 2012 12:08:43 +0000, Marcus Shawcroft <marcus.shawcroft@linaro.org> wrote:
> This patch addresses the comment on choice of file name  raised by Andreas here:
> 
> http://sourceware.org/ml/libc-ports/2012-11/msg00066.html
> 
> /Marcus
> 
> 2012-11-19  Marcus Shawcroft  <marcus.shawcroft@linaro.org>
> 
>         * sysdeps/aarch64/fpu/s_frint.x: Renamed to...
>         * sysdeps/aarch64/fpu/s_frint.c: New file.

Typically the following style is used, as far as I can tell:

	* sysdeps/aarch64/fpu/s_frint.c: ... this new file.

>         * sysdeps/aarch64/fpu/s_frintf.x: Renamed to...
>         * sysdeps/aarch64/fpu/s_frintf.c: New file.
>         * sysdeps/aarch64/fpu/s_ceil.c: Include s_frint.c.
>         * sysdeps/aarch64/fpu/s_floor.c: Likewise.
>         * sysdeps/aarch64/fpu/s_nearbyint.c: Likewise.
>         * sysdeps/aarch64/fpu/s_rint.c: Likewise.
>         * sysdeps/aarch64/fpu/s_round.c: Likewise.
>         * sysdeps/aarch64/fpu/s_trunc.c: Likewise.
>         * sysdeps/aarch64/fpu/s_ceilf.c: Include s_frintf.c.
>         * sysdeps/aarch64/fpu/s_floorf.c: Likewise.
>         * sysdeps/aarch64/fpu/s_nearbyintf.c: Likewise.
>         * sysdeps/aarch64/fpu/s_rintf.c: Likewise.
>         * sysdeps/aarch64/fpu/s_roundf.c: Likewise.
>         * sysdeps/aarch64/fpu/s_truncf.c: Likewise.

Looks good to me.

(Using ranges for copyright years is part of another patch.)


GrÃÃe,
 Thomas

Attachment: pgp00000.pgp
Description: PGP signature

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]