This is the mail archive of the
libc-ports@sources.redhat.com
mailing list for the libc-ports project.
Re: Patch: Convert ia64 to use <bits/fcntl-linux.h>
- From: Andreas Jaeger <aj at suse dot com>
- To: Mike Frysinger <vapier at gentoo dot org>
- Cc: "libc-ports at sourceware dot org" <libc-ports at sourceware dot org>
- Date: Thu, 25 Oct 2012 08:06:30 +0200
- Subject: Re: Patch: Convert ia64 to use <bits/fcntl-linux.h>
- References: <50883CBE.60805@suse.com> <201210241628.04405.vapier@gentoo.org>
On 10/24/2012 10:28 PM, Mike Frysinger wrote:
On Wednesday 24 October 2012 15:08:46 Andreas Jaeger wrote:
#define F_GETLK 5 /* Get record locking info. */
#define F_SETLK 6 /* Set record locking info (non-blocking). */
#define F_SETLKW 7 /* Set record locking info (blocking). */
pretty sure these three can get deleted too
Yes, we can remove them.
#define F_SETLK64 6 /* Set record locking info (non-blocking). */
#define F_SETLKW64 7 /* Set record locking info (blocking). */
for these three, i wonder if we could make bits/fcntl-linux.h smarter. like:
#ifndef F_GETLK64
# if __O_LARGEFILE
<current defines to 12/13/14>
# else
<new defines to the non-64bit versions>
# endif
#endif
we'd have to tweak the logic so F_GETLK also does:
#ifndef F_GETLK
# if !defined __USE_FILE_OFFSET64 && __O_LARGEFILE
<current defines to 5/6/7>
...
Yes, this could work. Would it be ok for you if I look at this in a
separate step once everything else is commited?
Thus, may I add the current patch (with the removal of F_GETLK etc) for
Itanium?
Andreas
--
Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg)
GPG fingerprint = 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126