This is the mail archive of the
libc-ports@sources.redhat.com
mailing list for the libc-ports project.
Re: Patch: Convert linux-generic to use <bits/fcntl-linux.h>
- From: Roland McGrath <roland at hack dot frob dot com>
- To: Andreas Jaeger <aj at suse dot com>
- Cc: Chris Metcalf <cmetcalf at tilera dot com>, "libc-ports at sourceware dot org" <libc-ports at sourceware dot org>, libc-alpha <libc-alpha at sourceware dot org>
- Date: Wed, 24 Oct 2012 13:36:11 -0700 (PDT)
- Subject: Re: Patch: Convert linux-generic to use <bits/fcntl-linux.h>
- References: <50883C05.5090807@suse.com> <508841FA.4060104@tilera.com> <508849BF.50205@suse.com>
> We could have:
> #ifdef __USE_LARGEFILE64
> # if __WORDSIZE == 64
> # define O_LARGEFILE 0
> # else
> # define O_LARGEFILE __O_LARGEFILE
> # endif
> #endif
That's too much hair. If there is a majority common value for
__O_LARGEFILE, then you can default __O_LARGEFILE to that value.
Beyond that, I'd say just leave it alone.