This is the mail archive of the
libc-ports@sources.redhat.com
mailing list for the libc-ports project.
Re: [PATCH] Get rid of ASM_SIZE_DIRECTIVE
- From: Carlos O'Donell <carlos_odonell at mentor dot com>
- To: Marek Polacek <polacek at redhat dot com>
- Cc: <libc-alpha at sourceware dot org>, libc-ports <libc-ports at sourceware dot org>, Kaz Kojima <kkojima at rr dot iij4u dot or dot jp>, Andreas Krebbel <krebbel at linux dot vnet dot ibm dot com>, David Miller <davem at davemloft dot net>
- Date: Mon, 17 Sep 2012 11:03:50 -0400
- Subject: Re: [PATCH] Get rid of ASM_SIZE_DIRECTIVE
- References: <20120917141912.GE1265@redhat.com>
On 9/17/2012 10:19 AM, Marek Polacek wrote:
> Removal of ASM_SIZE_DIRECTIVE macro. I did not touch the ports/
> directory. Tested x86_64 and i?86, tested also {libc,ld}.so with
> objdump -dr. Could you please also test sh, ppc, and s390
> as well? Thanks. Ok for trunk?
I'm sorry if I'm asking a dumb question, but why are we removing ASM_SIZE_DIRECTIVE?
Did we agree that it's easier to read ".size ..." and that a macro for this is just superfluous?
Cheers,
Carlos.
--
Carlos O'Donell
Mentor Graphics / CodeSourcery
carlos_odonell@mentor.com
carlos@codesourcery.com
+1 (613) 963 1026