This is the mail archive of the libc-ports@sources.redhat.com mailing list for the libc-ports project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH roland/arm-hwcap-vfp] don't use HWCAP_ARM_* in OS-independent code


On Thu, 9 Aug 2012, Roland McGrath wrote:

> > __VFP_FP__ doesn't mean "generating VFP instructions", it means 
> > "floating-point types have VFP layout" (i.e. normal IEEE floating-point 
> > with the same byte ordering / endianness as integer types, as opposed to 
> > FPA format), which is always true for EABI.  The relevant test for 
> > "generating VFP instructions" is defined __VFP_FP__ && !defined __SOFTFP__ 
> > (which can be simplified to just !defined __SOFTFP__ given that EABI is 
> > assumed).
> 
> Thanks for the explanation.  I've changed the conditionals.  On further
> reflection I also decided that using ldsodefs.h was just too ugly and I've
> added an arm-features.h instead.
> 
> How does this look now?

This version is OK.

-- 
Joseph S. Myers
joseph@codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]