This is the mail archive of the libc-ports@sources.redhat.com mailing list for the libc-ports project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 2/3, MIPS] Rewrite MIPS' pthread_spin_[try]lock using __atomic_* builtins.


On Thu, 14 Jun 2012, Maxim Kuvyrkov wrote:

> 2012-06-13  Tom de Vries  <vries@codesourcery.com>
> 	    Maxim Kuvyrkov  <maxim@codesourcery.com>
> 
> 	* sysdeps/mips/nptl/pthread_spin_[try]lock.S: Remove.
> 	* sysdeps/mips/nptl/pthread_spin_[try]lock.c: New files.

You need to list each file individually rather than writing 
"pthread_spin_[try]lock.S".  See the GNU Coding Standards.

> diff --git a/sysdeps/mips/nptl/pthread_spin_trylock.c b/sysdeps/mips/nptl/pthread_spin_trylock.c
> new file mode 100644
> index 0000000..ed75813
> --- /dev/null
> +++ b/sysdeps/mips/nptl/pthread_spin_trylock.c

This file looks generic and essentially the same as the ARM and M68K 
versions.  I think it would be better to put such a generic version in a 
generic directory (maybe directly in nptl/), and remove the ARM and M68K 
copies, rather than adding a third copy of the same generic 
implementation.

-- 
Joseph S. Myers
joseph@codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]