This is the mail archive of the
libc-ports@sources.redhat.com
mailing list for the libc-ports project.
Re: [PATCH 2/3, MIPS] Rewrite MIPS' pthread_spin_[try]lock using __atomic_* builtins.
- From: "Joseph S. Myers" <joseph at codesourcery dot com>
- To: Maxim Kuvyrkov <maxim at codesourcery dot com>
- Cc: Richard Sandiford <rdsandiford at googlemail dot com>, <libc-ports at sourceware dot org>
- Date: Thu, 28 Jun 2012 23:10:01 +0000
- Subject: Re: [PATCH 2/3, MIPS] Rewrite MIPS' pthread_spin_[try]lock using __atomic_* builtins.
- References: <2109EAD5-BBE8-4C8C-8D61-0AF33290F240@codesourcery.com>
On Thu, 14 Jun 2012, Maxim Kuvyrkov wrote:
> 2012-06-13 Tom de Vries <vries@codesourcery.com>
> Maxim Kuvyrkov <maxim@codesourcery.com>
>
> * sysdeps/mips/nptl/pthread_spin_[try]lock.S: Remove.
> * sysdeps/mips/nptl/pthread_spin_[try]lock.c: New files.
You need to list each file individually rather than writing
"pthread_spin_[try]lock.S". See the GNU Coding Standards.
> diff --git a/sysdeps/mips/nptl/pthread_spin_trylock.c b/sysdeps/mips/nptl/pthread_spin_trylock.c
> new file mode 100644
> index 0000000..ed75813
> --- /dev/null
> +++ b/sysdeps/mips/nptl/pthread_spin_trylock.c
This file looks generic and essentially the same as the ARM and M68K
versions. I think it would be better to put such a generic version in a
generic directory (maybe directly in nptl/), and remove the ARM and M68K
copies, rather than adding a third copy of the same generic
implementation.
--
Joseph S. Myers
joseph@codesourcery.com