This is the mail archive of the libc-ports@sources.redhat.com mailing list for the libc-ports project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: RFA: Port maintainers: Convert WORDSIZE[32|64]/ld to abi-variants


On Fri, Jun 1, 2012 at 7:06 AM, Joseph S. Myers <joseph@codesourcery.com> wrote:
> On Thu, 31 May 2012, H.J. Lu wrote:
>
>> On Thu, May 31, 2012 at 8:17 AM, Joseph S. Myers
>> <joseph@codesourcery.com> wrote:
>> > HJ, I don't see how default-abi gets set for powerpc, s390 or sparc - I
>> > think you're missing appropriate settings in six sysdeps makefiles for
>> > those.
>> >
>> > The setting in Makeconfig
>> >
>> > ifdef abi-variants
>> > ifndef default-abi
>> > default-abi = $(firstword $(abi-variants))
>> > endif
>> > endif
>>
>> This should be removed then and powerpc, s390 or sparc
>> should define default-abi. ?But I don't know them well enough
>> to add it myself.
>
> Here is the (untested) patch I propose to add the default-abi definitions
> so that these architectures again install the correct stubs-<abi>.h
> instead of "stubs-.h".
>

Can you also remove

ifdef abi-variants
ifndef default-abi
default-abi = $(firstword $(abi-variants))
endif
endif

in Makeconfig?

Thanks.

-- 
H.J.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]