This is the mail archive of the
libc-ports@sources.redhat.com
mailing list for the libc-ports project.
Re: Support sharing ARM headers for hard and soft float
On Wed, 30 May 2012, Roland McGrath wrote:
> > +default-abi := $(strip $(shell \
> > + ($(default-abi-prog)) | $(CC) $(CFLAGS) $(CPPFLAGS) -E -P -))
>
> Using $(shell ...) in makefiles is pretty disgusting. The compiler
> will run every time you run make. What I'd recommend instead is
> generating a makefile and including it. The generated file can depend
> on config.make or something like that to be sure it gets re-run when
> $(CC) et al might reasonably be expected to have changed.
What I really want here is an AC_SUBSTed makefile variable, set by the
same configure test that puts a definition in config.h with AC_DEFINE.
But I think that's harder to do cleanly (completely independently for each
port) than sorting out the config.h issue (bug 14068); autoconf appears to
want to put all the AC_SUBSTed variables in one shell variable setting in
configure initialization, which isn't really conducive to configure
fragments adding their own.
--
Joseph S. Myers
joseph@codesourcery.com