This is the mail archive of the
libc-ports@sources.redhat.com
mailing list for the libc-ports project.
Re: Restore MIPS n64 posix_fadvise64 export at GLIBC_2.3.3 (bug 14044)
On Tue, 1 May 2012, Matt Turner wrote:
> On Tue, May 1, 2012 at 12:00 PM, Joseph S. Myers
> <joseph@codesourcery.com> wrote:
> > Similar to the ABI comparisons I did for ARM with old binaries, I also did
> > such comparisons for MIPS. ?This showed that n64's export of
> > posix_fadvise64 at version GLIBC_2.3.3 had disappeared as a result of my
> > patch <http://sourceware.org/ml/libc-ports/2009-12/msg00001.html>. ?The
> > ABI was to export posix_fadvise64 at both GLIBC_2.2 and GLIBC_2.3.3 (with
> > identical semantics - there was no need for the two symbol versions on
> > n64, but given that glibc was released with them they should both stay as
> > part of the ABI), so I've applied this patch to restore the GLIBC_2.3.3
> > export.
>
> Can't we just chalk this up to a happy accident and leave it out? If
> no one noticed between 2.3.3 and now, the symbol can't be needed.
It's not "between 2.3.3 and now", it's between December 2009
(2.10/2.11/2.12) and now, and people often skip a few glibc releases. We
shouldn't drop symbols just because they are obscure.
--
Joseph S. Myers
joseph@codesourcery.com