This is the mail archive of the libc-ports@sources.redhat.com mailing list for the libc-ports project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v2 0/10] Tilera (and Linux asm-generic) support for glibc


On 11/11/2011 1:10 PM, Roland McGrath wrote:
>> Do you mean the Subject lines all being the same in the emails that make up 
>> each patch set?  I almost gave them all different subject lines to match 
>> the contents, but at the last minute "saved" myself by reading in the 
>> sourceware glibc "Contribution checklist" wiki 
>> (http://sourceware.org/glibc/wiki/Contribution%20checklist):
> 
> Those instructions are stupid.  Using a distinct and meaningful subject
> line for each patch is the true convention.

The instructions as written do not lack meaning or sense, but it does appear that they are inaccurate with respect to your ideals on the topic.

Personally I like the use of a repeating prefix coupled with a meaningful subject line e.g. [PATCH 9/10] NPTL update: <Meaningful subject>.

Unfortunately we get so few patch sets in glibc that this issue is mostly moot.

I've updated the wiki to reflect your comments.

http://sourceware.org/glibc/wiki/Contribution%20checklist#Contribution_Email_Subject_Line

Cheers,
Carlos.
-- 
Carlos O'Donell
Mentor Graphics / CodeSourcery
carlos@codesourcery.com
+1 (613) 963 1026


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]