This is the mail archive of the libc-ports@sources.redhat.com mailing list for the libc-ports project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix SOCK_CLOEXEC on HPPA to match O_CLOEXEC


On Tue, Feb 16, 2010 at 8:46 AM, Carlos O'Donell
<carlos@systemhalted.org> wrote:
> On Fri, Feb 12, 2010 at 11:54 PM, Matt Turner <mattst88@gmail.com> wrote:
>> Firstly, commit fa1b9bae63 tried to fix the value of SOCK_CLOEXEC,
>> but missed a trailing 0.
>
> Thanks Matt!
>
>> Secondly, the Changelog.hppa says the fix is from Kyle McMartin,
>> but git thinks the author is Carlos. I definitely think these two
>> should always match. Use git commit --author=... next time.
>
> That's true, I checked in the patch for Kyle. Is this what other
> projects do when using GIT to checkin patches for others?

Yeah, this is pretty standard procedure and is used in the couple of
projects I'm involved with, namely the Linux kernel and Xorg and
friends.

> The GNU C Library project is new to GIT so we don't have much procedure.
>
> Would you mind sending an email to libc-alpha@sourceware.org
> suggesting this change in procedure?

Do other people not do this? Looks like all my patches that Joseph has
committed are attributed to me in git. I don't see anything committed
to glibc.git by anyone other than Ulrich Drepper, but plenty of
authors.

Matt


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]