This is the mail archive of the
libc-ports@sources.redhat.com
mailing list for the libc-ports project.
Re: Too large messages on glibc-cvs@
- From: Jim Meyering <jim at meyering dot net>
- To: Petr Baudis <pasky at suse dot cz>
- Cc: "GNU C. Library" <libc-alpha at sourceware dot org>, libc-ports at sourceware dot org
- Date: Wed, 04 Nov 2009 17:14:18 +0100
- Subject: Re: Too large messages on glibc-cvs@
- References: <1244556143.2831.ezmlm-warn@sourceware.org> <20090609144835.GC8501@machine.or.cz> <20090609205838.65E49FC3C5@magilla.sf.frob.com> <87tz2p3yhn.fsf@meyering.net> <20091104121439.GE3708@machine.or.cz>
Petr Baudis wrote:
> On Tue, Jun 09, 2009 at 11:09:56PM +0200, Jim Meyering wrote:
>> Roland McGrath wrote:
>> > Jim is our local expert on the git scripts.
>> > But I'm sure this issue is not new among all other projects using git.
>> > If anybody else has script hacks for this stuff, please come forward.
>>
>> I noticed those, too. I wrote/posted a tiny script to insert into the
>> existing hook. I'll actually test and install it Thursday or Friday.
>
> I'm now adding this hook to repo.or.cz and I'd like to do this too,
> I'm wondering, how did you do this?
Hi Petr,
I wrote this limit-pipe script:
http://sourceware.org/ml/libc-ports/2009-05/msg00056.html
but I never got around to making the hook use it.
I can do something like this to the post-receive-email script
we're currently using (with a probable PATH update):
- generate_email $oldrev $newrev $refname | send_mail
+ generate_email $oldrev $newrev $refname |
+ limit-pipe 524288 | send_mail
On second thought, that limit, 512KB (just made up by me, btw),
has to come from config, set via e.g.,
git config hooks.email-max-size 524288
since it's per-repo policy, while the hook script is typically shared.
On the other hand, since no one has complained about overly-large
messages in 4 months, maybe it's not worth doing after all.
If no one says they want it (and provides a max message size),
I'll presume there's no need. Same applies to libc-ports.
Jim