This is the mail archive of the
libc-ports@sources.redhat.com
mailing list for the libc-ports project.
Re: Update ARM and MIPS ports for libc changes
- From: "Carlos O'Donell" <carlos at systemhalted dot org>
- To: "Joseph S. Myers" <joseph at codesourcery dot com>
- Cc: libc-ports at sourceware dot org, "Daniel Jacobowitz" <dan at codesourcery dot com>
- Date: Wed, 12 Sep 2007 10:36:13 -0400
- Subject: Re: Update ARM and MIPS ports for libc changes
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth; bh=++LxLKbC3dlZTUeR56kfSqE/DT1czzHlQv4cr/fWoBo=; b=YnBuDlYe+y7t2NF3ObcNhwPMaoWf5p2ixixj23C61WsaFPKvYLT1MCVEFOHdMYxL7M3RCgFE5p3oEK8EGQbuBN1GlT/lbLRELPAgGv00fmoyBgADkFEKcwGaU58eQImAoowZptNnadSBelA00D4z9FTdq/URXKKGc6ha7kJh5X0=
- Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth; b=I5HSm04FrEZyniMrhgK/Goh/1GhBmNKpID7tQSx1o5+gotZ3VHp//jaDLAkuK90G1rXj3qq+CbEprMm/kDguUaMXNWqtWy02ZczhGVuTnz5xTv040PouKmr1WM1QJW+2wRdNvaZMpVZ+CJFHOneuNJb+S/rK4IVseEfaxritA7A=
- References: <Pine.LNX.4.64.0709112353180.13694@digraph.polyomino.org.uk>
On 9/11/07, Joseph S. Myers <joseph@codesourcery.com> wrote:
> This patch updates the ARM and MIPS ports for changes to libc over the
> past several months. (Other ports may well also need updates - HPPA for
> the private futex changes, various for new defines in headers and extern
> inline fixes.)
I finished all the HPPA patches on the weekend, and haven't had time
to verify that the testsuite run shows no regressions. I will probably
do that this coming weekend.
> There are some new header defines and extern inline fixes, but the bulk is
> private futex updates, where I've tried to follow various the examples of
> various targets in libc as guidance. Two points of particular note:
> <sysdep.h> needs to include <tls.h> for consistency with libc targets to
> get the <tls.h> definitions in some source files; <lowlevellock.h> gets
> indirectly included from the middle of headers such as <atomic.h> and
> <tls.h> which means that inline functions in <lowlevellock.h> can't use
> all the macros from those two headers and some such inline functions have
> had to change to macros to avoid this problem (as has been done for
> various targets in libc).
I tracked down the header dependency issue to the following apparently
unneeded inclusion of lowlevellock.h. Removing the include of
lowlevelock.h from nptl/descr.h fixes the problem for hppa.
--- descr.h 1 Aug 2007 04:09:32 -0000 1.42
+++ descr.h 12 Sep 2007 14:33:25 -0000
@@ -27,7 +27,7 @@
#include <sys/types.h>
#include <hp-timing.h>
#include <list.h>
-#include <lowlevellock.h>
#include <pthreaddef.h>
#include <dl-sysdep.h>
#include "../nptl_db/thread_db.h"
Why is descr.h including lowlevellock.h? It doesn't use any of the
definitions therein.
Cheers,
Carlos.