This is the mail archive of the
libc-ports@sources.redhat.com
mailing list for the libc-ports project.
Re: [PATCH] Fix some system calls with long long arguments
- From: Atsushi Nemoto <anemo at mba dot ocn dot ne dot jp>
- To: libc-ports at sourceware dot org
- Cc: drow at false dot org, ralf at linux-mips dot org
- Date: Fri, 25 May 2007 01:07:46 +0900 (JST)
- Subject: Re: [PATCH] Fix some system calls with long long arguments
- References: <20070521.133841.63132735.nemoto@toshiba-tops.co.jp>
On Mon, 21 May 2007 13:38:41 +0900 (JST), Atsushi Nemoto <anemo@mba.ocn.ne.jp> wrote:
> I filed it at glibc bugzilla:
>
> http://sources.redhat.com/bugzilla/show_bug.cgi?id=4526
Now it closed. Thanks.
But unfortunately my patch had a typo, sorry. Please commit this too.
2007-05-25 Atsushi Nemoto <anemo@mba.ocn.ne.jp>
* sysdeps/unix/sysv/linux/mips/mips32/posix_fadvise.c
(posix_fadvise): Fix high word of len argument.
diff -urNp glibc-ports-2.6.org/sysdeps/unix/sysv/linux/mips/mips32/posix_fadvise.c glibc-ports-2.6/sysdeps/unix/sysv/linux/mips/mips32/posix_fadvise.c
--- glibc-ports-2.6.org/sysdeps/unix/sysv/linux/mips/mips32/posix_fadvise.c 2007-05-24 02:26:13.000000000 +0900
+++ glibc-ports-2.6/sysdeps/unix/sysv/linux/mips/mips32/posix_fadvise.c 2007-05-25 00:52:38.000000000 +0900
@@ -31,7 +31,7 @@ posix_fadvise (int fd, off_t offset, off
INTERNAL_SYSCALL_DECL (err);
int ret = INTERNAL_SYSCALL (fadvise64, err, 7, fd, 0,
__LONG_LONG_PAIR (offset >> 31, offset),
- __LONG_LONG_PAIR (offset >> 31, len),
+ __LONG_LONG_PAIR (len >> 31, len),
advise);
if (INTERNAL_SYSCALL_ERROR_P (ret, err))
return INTERNAL_SYSCALL_ERRNO (ret, err);