This is the mail archive of the libc-ports@sources.redhat.com mailing list for the libc-ports project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: MIPS build updates


On Mon, 8 May 2006 15:23:56 -0400, Daniel Jacobowitz <drow@false.org> wrote:
> Richard Sandiford sent me two patches which fix the MIPS port build in
> HEAD: one to update for the changes to ldsodefs.h, and one to provide
> the newly mandatory fields in struct stat.  I've committed both of
> these.
> 
> 2006-05-08  Richard Sandiford  <richard@codesourcery.com>
> 
> 	* sysdeps/mips/ldsodefs.h: New file.
> 	* sysdeps/mips/tst-audit.h: New file.

I just noticed this slightly old commit contains strange lines:

> --- /dev/null	2003-08-21 05:59:20.000000000 +0000
> +++ libc/ports/sysdeps/mips/ldsodefs.h	2006-05-08 09:27:39.000000000 +0000
> @@ -0,0 +1,66 @@
...
> +#ifndef __LDSODEFS_H \
> +#define _MIPS_LDSODEFS_H 1

This cause a "extra tokens at end of #ifndef directive" warning.

And it woule be better to make __LDSODEFS_H and _MIPS_LDSODEFS_H
consistent.  (_MIPS_LDSODEFS_H is already used in
sysdeps/mips/elf/ldsodefs.h so using __LDSODEFS_H is preferred?)

---
Atsushi Nemoto


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]