This is the mail archive of the libc-ports@sources.redhat.com mailing list for the libc-ports project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: New mailing list <libc-ports@sources.redhat.com>


For the trunk patches, you should post each unrelated change separately.
Remember, for each change that you also need to see on the 2.3 branch,
a bugzilla report is required.

> 	* Makeconfig (libc.so-gnulib): Added -lgcc_s$(libgcc_s_suffix)
> 	to avoid undefined _Unwind_Find_FDE.

Can you explain why this is needed?  This should not differ from other
platforms where it hasn't been required.

> 	* elf/elf.h (R_M32R_REL32): Added a relocation number.

This one could go in.  Fix up the whitespace in the comments and post it
alone to libc-alpha.  If there are other missing R_M32R_* numbers, or ones
whose comments should be improved, do that as well.

> 	* sysdeps/unix/sysv/linux/futimes.c (__futimes): Use __libc_fcntl
> 	instead of INLINE_SYSCALL macro to avoid undefined __NR_fcntl.
> 	(M32r doesn't provide __NR_fcntl.)

Don't deoptimize other configurations to support yours.
If this is really necessary, conditionalize it on __NR_fcntl.

> 	* sysdeps/unix/sysv/linux/i386/fcntl.c: Include "kernel-features.h"
> 	instead of "../kernel-features.h".
> 	(ports/sysdeps/unix/sysv/linux/m32r/fcntl.c include this file.)

If you want it to be searched for the right thing is <>.  Using "" means it
will get i386/kernel-features.h if that were to exist.


Thanks,
Roland


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]