This is the mail archive of the
libc-help@sourceware.org
mailing list for the glibc project.
Re: [PATCH 1/2] Avoid duplication of _CLOEXEC and _NONBLOCK values
- From: "Carlos O'Donell" <carlos at systemhalted dot org>
- To: Guy Martin <gmsoft at tuxicoman dot be>
- Cc: libc-help at sourceware dot org
- Date: Sun, 8 Aug 2010 15:20:48 -0400
- Subject: Re: [PATCH 1/2] Avoid duplication of _CLOEXEC and _NONBLOCK values
- References: <1281176816-4072-1-git-send-email-gmsoft@tuxicoman.be>
On Sat, Aug 7, 2010 at 6:26 AM, Guy Martin <gmsoft@tuxicoman.be> wrote:
> This patch define all the _CLOEXEC and _NONBLOCK derived values as O_CLOEXEC and
> O_NONBLOCK respectively. This avoids a lot of header duplication and a handfull of
> obsolete files can be removed.
I've moved this to libc-help to help you cleanup the submission before
going to libc-alpha.
(1) Please provide just the ChangeLog.
Please see:
http://sourceware.org/glibc/wiki/Contribution%20checklist
This is point #7:
http://sourceware.org/glibc/wiki/Contribution%20checklist#GNU_ChangeLog
(2) Please tackle one problem at a time.
Create a patch that *just* updates the generic headers to use the new constants.
This would split your patch set in three sets:
(a) Generic update to use constants.
(b) Sparc cleanup.
(c) x86_64 cleanup.
Please post the new patches on libc-help.
Cheers,
Carlos.