This is the mail archive of the libc-help@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFC] [PATCH] sched_getaffinity() fails with -EINVAL


On Thu, Oct 29, 2009 at 2:49 AM, Sharyathi Nagesh <sharyath@in.ibm.com> wrote:
> Hi
> ? ? ? ?This is the patch I am proposing to fix the issue, I had mentioned
> earlier in this mailing list.
> ? ? ? ?Is it possible to accommodate the patch in glibc ?
> ? ? ? ? ? ? ? ?This increased the CPU SETSIZE to reflect kernel
> capabilities. Other wise cpuset data structures will support only 1096 CPUS
> while kernel can do 4096.

As Bert suggests you could port your code to the CPU_*_S macros
instead of using sched_*affinity() functions.

However, since both APIs work on the same data, it would be nice to
have both of them working and supporting the max cpu set size
supported by the kernel.

Your patch however lacks a lot of thing, please see the contribution checklist:
http://sourceware.org/glibc/wiki/Contribution%20checklist

In particular please show that changing this constant doesn't cause
problems when booting on older kernels.

Cheers,
Carlos.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]