This is the mail archive of the libc-help@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: Need help in properly formatting a patch for glibc

From: Denys Vlasenko <dvlasenk at redhat dot com>
To: "Carlos O'Donell" <carlos at systemhalted dot org>
Cc: Ryan Arnold <ryan dot arnold at gmail dot com>, libc-help at sourceware dot org
Date: Tue, 19 Aug 2008 10:57:30 +0200
Subject: Re: Need help in properly formatting a patch for glibc
References: <1219073537.13567.11.camel@localhost.localdomain> <ff4da150808180842v31c37d79j9669efe5182b1ce@mail.gmail.com> <119aab440808181228l6bb26d3end40502cddd77050e@mail.gmail.com>

On Mon, 2008-08-18 at 15:28 -0400, Carlos O'Donell wrote:
> On Mon, Aug 18, 2008 at 11:42 AM, Ryan Arnold <ryan.arnold@gmail.com> wrote:
> > On Mon, Aug 18, 2008 at 10:32 AM, Denys Vlasenko <dvlasenk@redhat.com> wrote:
> >> Please advice what I did wrong, and what is the correct Changelog
> >> format.
> 
> Your patch also lacks the following:
> 
> 1. A detailed explanation of the patch.
> e.g. Under what conditions does it occur?

Details are at https://bugzilla.redhat.com/show_bug.cgi?id=457508

> 2. Testing.
> e.g. After patching glibc, did you run the testsuite to verify your
> patch didn't break anything?

Yes, it does not break anything.
--
vda

Follow-Ups:
- Re: Need help in properly formatting a patch for glibc
  - From: Carlos O'Donell

References:
- Need help in properly formatting a patch for glibc
  - From: Denys Vlasenko
- Re: Need help in properly formatting a patch for glibc
  - From: Ryan Arnold
- Re: Need help in properly formatting a patch for glibc
  - From: Carlos O'Donell

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]