This is the mail archive of the
mailing list for the glibc project.
Re: pthread_cond_* does not compile on i386
- From: Gilles Carry <Gilles dot Carry at bull dot net>
- To: Carlos O'Donell <carlos at systemhalted dot org>
- Cc: libc-help at sourceware dot org
- Date: Mon, 05 May 2008 08:55:12 +0200
- Subject: Re: pthread_cond_* does not compile on i386
- References: <48185CA9.firstname.lastname@example.org> <email@example.com>
Carlos O'Donell wrote:
On Wed, Apr 30, 2008 at 7:48 AM, Gilles Carry <Gilles.Carry@bull.net> wrote:
After having removed the corresponding asm files, pthread_cond_signal.c
Why would you remove the asm files that implement the required behaviour?
Just because I wanted to add new features into condvars.
Actually, pthread_cond_signal.c uses the macro lll_futex_wake_unlock
which is not defined for i386.
At least I cannot find it by grepping through the source tree.
To have it compiling, I had to rework the syscall macros.
Though I can build the rest of glibc without error, I wonder if the C code
and asm-i386 are in sync for pthread_cond_* files.
They don't need to be kept "in sync", the i386 port probably doesn't
rely on the C code variants of these functions.
I thought asm files were supposed to be only optimizations of existing C
It makes sense to me to modify generic c code first and optimize afterward.
ie. pthread_cond_wait.c is not trivial enough to skip the generic
C-coding phase and go directly to asm code.
May be I'm missing something.