This is the mail archive of the libc-hacker@sourceware.org mailing list for the glibc project.

Note that libc-hacker is a closed list. You may look at the archives of this list, but subscription and posting are not open.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

[PATCH] Fix ia64 feraiseexcept

From: Jakub Jelinek <jakub at redhat dot com>
To: Ulrich Drepper <drepper at redhat dot com>, "H. J. Lu" <hongjiu dot lu at intel dot com>
Cc: Glibc hackers <libc-hacker at sources dot redhat dot com>
Date: Tue, 8 May 2007 23:38:15 +0200
Subject: [PATCH] Fix ia64 feraiseexcept
Reply-to: Jakub Jelinek <jakub at redhat dot com>

Hi!

While feraiseexcept (FE_OVERFLOW); or feraiseexcept (FE_UNDERFLOW) are
allowed to raise additionally inexact exception, feraiseexcept (FE_INEXACT)
shouldn't raise any exception but inexact.

DBL_MAX + 1.0 overflows and is inexact though, while (DBL_MAX / 2.0) + 1.0
is only inexact, but doesn't overflow.

Fixes test-fenv.

2007-05-08  Jakub Jelinek  <jakub@redhat.com>

	* sysdeps/ia64/fpu/fraiseexcpt.c (feraiseexcept): Don't raise overflow
	exception in addition to inexact when asked to raise only FE_INEXACT.

--- libc/sysdeps/ia64/fpu/fraiseexcpt.c.jj	2003-11-29 08:28:46.000000000 +0100
+++ libc/sysdeps/ia64/fpu/fraiseexcpt.c	2007-05-08 23:22:55.000000000 +0200
@@ -1,5 +1,6 @@
 /* Raise given exceptions.
-   Copyright (C) 1997, 1998, 2000, 2001, 2002 Free Software Foundation, Inc.
+   Copyright (C) 1997, 1998, 2000, 2001, 2002, 2007
+   Free Software Foundation, Inc.
    This file is part of the GNU C Library.
    Contributed by Jes Sorensen <Jes.Sorensen@cern.ch>, 2000.
 
@@ -69,7 +70,7 @@ feraiseexcept (int excepts)
   /* Last: inexact.  */
   if (FE_INEXACT & excepts)
     {
-      dummy = DBL_MAX;
+      dummy = DBL_MAX / 2.0;
       __asm__ __volatile__ ("fadd.d.s0 %0=%1,f1" : "=f" (dummy) : "0" (dummy));
     }
 

	Jakub

Follow-Ups:
- [PATCH] Fix ia64 feraiseexcept (take 2)
  - From: Jakub Jelinek

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]