This is the mail archive of the libc-hacker@sourceware.org mailing list for the glibc project.

Note that libc-hacker is a closed list. You may look at the archives of this list, but subscription and posting are not open.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [BZ #2078, 2079] Fix some wide functions


Ulrich Drepper <drepper@redhat.com> writes:

> Andreas Jaeger wrote:
>> Index: libio/wfileops.c
>> --- libio/wfileops.c	14 Jan 2004 18:40:03 -0000	1.29
>> +++ libio/wfileops.c	15 Jan 2006 16:08:16 -0000
>> @@ -1,4 +1,4 @@
>> -/* Copyright (C) 1993,1995,1997-2003,2004 Free Software Foundation, Inc.
>> +/* Copyright (C) 1993,1995,1997-2003,2004, 2006 Free Software Foundation, Inc.
>>     This file is part of the GNU C Library.
>>     Written by Ulrich Drepper <drepper@cygnus.com>.
>>     Based on the single byte version by Per Bothner <bothner@cygnus.com>.
>> @@ -69,7 +69,7 @@ _IO_wdo_write (fp, data, to_do)
>>  	{
>>  	  if (_IO_new_do_write (fp, fp->_IO_write_base,
>>  				fp->_IO_write_ptr - fp->_IO_write_base) == EOF)
>> -	    return EOF;
>> +	    return WEOF;
>
> As far as fixing this specific kind of mistake, the patch is fine.  But
> there is something fishy in the use of _IO_wdo_write.

Will you take care of this, please?  I'll commit my patch now,

Andreas
-- 
 Andreas Jaeger, aj@suse.de, http://www.suse.de/~aj/
  SUSE Linux Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
   GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126

Attachment: pgp00000.pgp
Description: PGP signature


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]